Conversation
sullis
force-pushed
the
consolidate-lombok-config
branch
4 times, most recently
from
September 10, 2026 02:11
d5a4e5d to
6850300
Compare
sullis
force-pushed
the
consolidate-lombok-config
branch
3 times, most recently
from
September 10, 2026 02:48
028c6d2 to
dfc4575
Compare
sullis
marked this pull request as ready for review
September 10, 2026 03:13
Contributor
Author
|
Ready for review @greg-at-moderne @timtebeek |
greg-at-moderne
left a comment
Contributor
There was a problem hiding this comment.
The change itself looks line to me. I appreciate the defensive approach.
The only thing I'd kindly request is getting rid of the verbosity and excessive comments/texts.
sullis
force-pushed
the
consolidate-lombok-config
branch
2 times, most recently
from
September 17, 2026 18:00
6a07713 to
dfc4575
Compare
greg-at-moderne
self-requested a review
September 17, 2026 18:04
sullis
force-pushed
the
consolidate-lombok-config
branch
from
September 17, 2026 18:04
f424e96 to
0644d5e
Compare
Contributor
Author
I pushed an update. |
sullis
force-pushed
the
consolidate-lombok-config
branch
from
September 17, 2026 18:06
67f9cfb to
8f14a52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two
lombok.configrecipes, built on a sharedLombokConfighelper that parses a config file following the line grammar of Lombok's ownConfigurationParser. Both act on thelombok.configat the root of the repository, and read any*.configfile, since animportnames a file by path rather than by name.Neither recipe is part of
LombokBestPractices; both are registered inrecipes.csvand are run on their own.ConsolidateLombokConfigMerges the directives of every nested
lombok.configinto the rootlombok.configand deletes the nested files.import, are dropped rather than repeated; whitespace and key case are normalized for comparison only.config.stopBubblingor sits under a directory that does, it has animport,clearor-=, alombok.configbetween it and the root speaks about one of the same directives, anotherlombok.configimports it, no Java source sits at or below it, or it holds nothing but comments and unparseable lines.lombok.config, when two files assign conflicting values to the same key, when the rootclears or-=s a key a nested file speaks about, or when the root's imports cannot be resolved.Note that hoisting widens a directive's scope from one directory to the whole project, which the recipe description calls out.
AddStopBubblingToLombokConfigAppends
config.stopBubbling = trueto the rootlombok.configunless it already declares that key. Without it, Lombok keeps walking up past the project and alombok.configin a parent directory of the checkout takes part in the build.Tests
79 tests covering merging and merge order, deduplication, conflict detection, each non-hoistable case,
stopBubblingancestors, import resolution and cycles, comment handling, case-insensitive keys, Java-source layout, and CRLF and missing-trailing-newline root files.🤖 Generated with Claude Code