Preserve @{argLine} in AddSurefireFailsafeArgLine for JaCoCo coverage#1138
Merged
Conversation
When writing or merging a surefire/failsafe `argLine`, prepend Surefire's
`@{argLine}` late property reference so an agent injected into the `argLine`
property by an earlier plugin (e.g. JaCoCo `prepare-agent`) is preserved
rather than overwritten. The reference is not added when the existing
`argLine` already references the `argLine` property (`@{argLine}`/`${argLine}`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddSurefireFailsafeArgLinenow prepends Surefire's@{argLine}late property reference whenever it writes or merges a surefire/failsafeargLine, so an-javaagentinjected into theargLineproperty by an earlier plugin (most notably the JaCoCo coverage agent fromjacoco-maven-plugin:prepare-agent, but also the Mockito/ByteBuddy agent) is preserved instead of clobbered. The reference is not added when the existingargLinealready references theargLineproperty (@{argLine}or${argLine}), so the recipe stays idempotent and never duplicates it. Unlike${argLine}, the@{...}form is resolved when Surefire executes rather than at POM interpolation, so it picks up the value set during the build and resolves to an empty string when unset. Tests are updated for the new prefix, plus new cases covering JaCoCo coverage preservation and no-duplication of an existing reference; the generatedexamples.ymlis regenerated to match.