Explain why Kotlin modules are capped at Java 24 during Java 25 migration#1137
Merged
Conversation
…tion When migrating to Java 25, modules that compile Kotlin and depend on kotlin-stdlib older than 2.3 are capped at Java 24, since Kotlin <2.3 cannot target Java 25 bytecode. Previously this happened silently, leaving users confused why their pom.xml showed 24 instead of 25. Add CommentJava24KotlinCap, which annotates the capped Maven pom with an explanatory comment naming the kotlin-stdlib version found and the next step to reach Java 25. Wired into UpgradeBuildToJava24 so it runs scoped behind the same Kotlin preconditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When migrating to Java 25, modules that compile Kotlin and depend on
kotlin-stdlibolder than 2.3 are capped at Java 24 (Kotlin <2.3 cannot target Java 25 bytecode), which previously happened silently and left users confused why theirpom.xmlshowed 24 instead of 25. This addsCommentJava24KotlinCap, a Maven recipe that annotates the capped pom with an explanatory comment naming thekotlin-stdlibversion found and the next step to reach Java 25. It is wired intoUpgradeBuildToJava24so it runs scoped behind the same Kotlin preconditions, right after the version is capped, and is idempotent on re-runs. A test inUpgradeToJava25Testcovers the emitted comment.