Add software.amazon.ion:ion-java -> com.amazon.ion:ion-java relocation#185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
software.amazon.ion:ion-java→com.amazon.ion:ion-javarelocation soRelocatedDependencyCheckdetects (and can rewrite) the deprecated Amazon Ion group id.src/main/resources/migrations.csvfindRelocatedIonJavainRelocatedDependencyCheckTestWhy
From version 1.4.0 onward, Amazon Ion for Java moved to
com.amazon.ion; the legacysoftware.amazon.iongroup id is deprecated. The relocation was missing from the data set.Note — this is a stopgap
migrations.csvis auto-generated by the weeklyUpdate the Old GroupId migrations CSVworkflow from the upstreamoga-maven-plugindefinitions, so this manual row would be overwritten on the next run. The durable fix is upstream: Add software.amazon.ion:ion-java -> com.amazon.ion:ion-java relocation jonathanlermitage/oga-maven-plugin#123. This PR makes the recipe work before that upstream PR merges and regenerates the CSV. The regression test remains valid after regeneration.