feature: add server random and master key fetch api#2484
Draft
theweakgod wants to merge 2 commits intoopenresty:masterfrom
Draft
feature: add server random and master key fetch api#2484theweakgod wants to merge 2 commits intoopenresty:masterfrom
theweakgod wants to merge 2 commits intoopenresty:masterfrom
Conversation
theweakgod
changed the title
theweakgod
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add two new C-side FFI functions to support the corresponding Lua API in lua-resty-core's
ngx.sslmodule:ngx_http_lua_ffi_ssl_server_random(r, out, outlen, err)— retrieves the server random value via OpenSSL'sSSL_get_server_random().ngx_http_lua_ffi_ssl_session_master_key(r, out, outlen, err)— retrieves the session master key via OpenSSL'sSSL_SESSION_get_master_key().Both functions follow the same signature and behavior as the existing
ngx_http_lua_ffi_ssl_client_random().Why
The
ngx.sslmodule in lua-resty-core currently only exposesget_client_random(). To construct a complete NSS Key Log entry for Wireshark TLS decryption, the server random and master key are also needed:This enables users to debug HTTPS traffic in Lua without recompiling Nginx, using
LD_PRELOAD, or relying on NGINX Plus commercial directives.