Repository navigation
Advanced EMS setting: Add margin to power consumption and power production forecast - #117
Merged
Merged
Conversation
wborn
requested changes
Oct 5, 2026
wborn
left a comment
Member
There was a problem hiding this comment.
This is an initial AI-assisted review.
Two issues should be addressed before merging:
- Power-limit forecasts are no longer aligned with the consumption forecast by timestamp, which can apply limits to the wrong intervals and can also cause an
IndexOutOfBoundsExceptionwhen a limit series is incomplete. - Existing EMS assets will not automatically expose the newly added advanced settings because
advancedSettingsAttributesis only regenerated when its current value is blank.
There is also one clarification about whether the consumption and production uncertainty margins are intended to apply independently to their respective forecasts or based on the sign of the combined net forecast.
wborn
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First approve pull request #109
Fixes https://github.com/openremote/denhaag/issues/189