Skip to content

Advanced EMS setting: Add margin to power consumption and power production forecast - #117

Merged
wborn merged 4 commits into
mainfrom
ems-forecast-margin
Oct 7, 2026
Merged

wborn merged 4 commits into
mainfrom
ems-forecast-margin

Conversation

@igorrutka

@igorrutka igorrutka commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

First approve pull request #109

Fixes https://github.com/openremote/denhaag/issues/189

@wborn wborn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an initial AI-assisted review.

Two issues should be addressed before merging:

  • Power-limit forecasts are no longer aligned with the consumption forecast by timestamp, which can apply limits to the wrong intervals and can also cause an IndexOutOfBoundsException when a limit series is incomplete.
  • Existing EMS assets will not automatically expose the newly added advanced settings because advancedSettingsAttributes is only regenerated when its current value is blank.

There is also one clarification about whether the consumption and production uncertainty margins are intended to apply independently to their respective forecasts or based on the sign of the combined net forecast.

@wborn
wborn added this pull request to the merge queue Oct 7, 2026
Merged via the queue into main with commit 652c15a Oct 7, 2026
2 checks passed
@wborn
wborn deleted the ems-forecast-margin branch October 7, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants