Repository navigation
Conversation
dockfries
marked this pull request as ready for review
November 8, 2026 05:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the stale
zh-cn/andzh-tw/directories fromgh-pages.They are leftovers from before 425c9ac (March 2025), when I renamed the locale codes to
zh-CN/zh-TW. Really sorry I didn't catch this earlier — it's bloating the bundle file size for no reason.In other words, only
zh-CN/andzh-TW/should exist on the branch — having all four at once is the bug this PR fixes.Builds only emit the uppercase directories now, but the deploy action starts each commit from the previous
gh-pagestree and runs on macos-latest, whose case-insensitive filesystem preventsrsync --deletefrom removing case-only paths — so the old directories kept being refreshed instead of deleted.(
JamesIves/github-pages-deploy-actionusesrsyncinternally to sync and clean the deploy directory)Please merge this before other PRs that trigger a deployment:
gh-pagesis force-pushed on everymasterpush, so a deployment first would replace this PR's base and make it stale.After merging, the next deployment is the test — it should come out without
zh-cn/orzh-tw/.Also, just to note: the previous gh-pages deployment failed (run), but that is unrelated to this PR — it looks like an intermittent issue with upstream's
actions/deploy-pages@v5.