Add check for read-only config keys#1127
Open
Tiaansu wants to merge 1 commit intoopenmultiplayer:masterfrom
Open
Add check for read-only config keys#1127Tiaansu wants to merge 1 commit intoopenmultiplayer:masterfrom
Tiaansu wants to merge 1 commit intoopenmultiplayer:masterfrom
Conversation
- Add check for read-only keys when receiving onConsoleText (RCON) commands to prevent setting values for read-only config keys and having a weird behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check for read-only config keys when receiving commands in
onConsoleText, this now prevents setting a value for read-only configs during runtime, this is to avoid weird behaviors.