Repository navigation
Mark a test which we know fails when connected to the test server - #1787
Merged
Merged
Conversation
PGijsbers
added
serverside
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1787 +/- ##
===========================================
- Coverage 80.05% 51.84% -28.22%
===========================================
Files 63 63
Lines 5551 5551
===========================================
- Hits 4444 2878 -1566
- Misses 1107 2673 +1566 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PGijsbers
commented
Nov 5, 2026
Comment on lines
+129
to
150
| def test_v1_status_update(dataset_v1, static_cache_dir): | ||
| openml.config.apikey = TestBase.admin_key | ||
| arff_file_path = ( | ||
| static_cache_dir | ||
| / "org" | ||
| / "openml" | ||
| / "test" | ||
| / "data" | ||
| / "download" | ||
| / "1666876" | ||
| / "phpFsFYVN" | ||
| / "body.arff" | ||
| ) | ||
| new_dataset = OpenMLDataset( | ||
| f"TEST-{time.time()!s}-UploadTestWithURL", | ||
| "test", | ||
| "ARFF", | ||
| data_format="arff", | ||
| version=1, | ||
| url="https://www.openml.org/data/download/61/dataset_61_iris.arff", | ||
| licence="public", | ||
| default_target_attribute="class", | ||
| data_file=arff_file_path, | ||
| ) |
Member
Author
There was a problem hiding this comment.
URL uploading is now disabled on the server. This test doesn't really care about the particulars of the dataset being uploaded, so we just switch it to file upload. (I think this test isn't even really appropriate for openml-python to begin with, but that's not something I want to discuss as part of the PR but rather look at sometime separately).
L-Agbaria
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows CI still connects to the test server. There is an issue with the Elasticsearch instance on the test server which makes that particular test fail. This is a server-side issue, not something openml-python can fix. The issue seems to be persistent. For that reason I am marking the test as expected to fail when connecting to
test.openml.org. It works fine with local services (also use in CI, by the Ubuntu runners).