Skip to content

[ENH] V1 -> V2 Migration : Runs#1616

Merged
PGijsbers merged 321 commits into
openml:mainfrom
Omswastik-11:runs-migration-stacked
Jun 3, 2026
Merged

[ENH] V1 -> V2 Migration : Runs#1616
PGijsbers merged 321 commits into
openml:mainfrom
Omswastik-11:runs-migration-stacked

Conversation

@Omswastik-11
Copy link
Copy Markdown
Contributor

@Omswastik-11 Omswastik-11 commented Jan 15, 2026

Metadata

  • Reference Issue:
  • New Tests Added:
  • Documentation Updated:
  • Change Log Entry:

Details

fixes #1624

@geetu040 geetu040 mentioned this pull request Jan 15, 2026
18 tasks
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 72.35772% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.25%. Comparing base (3486b2a) to head (4f9e400).

Files with missing lines Patch % Lines
openml/_api/resources/run.py 75.94% 19 Missing ⚠️
openml/_api/clients/http.py 59.09% 9 Missing ⚠️
openml/runs/run.py 68.42% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1616      +/-   ##
==========================================
- Coverage   81.43%   81.25%   -0.19%     
==========================================
  Files          63       63              
  Lines        5149     5195      +46     
==========================================
+ Hits         4193     4221      +28     
- Misses        956      974      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync with base pr
sdk code look good so far, please take a look at #1575 (comment) and make changes accordingly where needed.
all tests (existing and new) should pass to make sure we are retaining the original functionality of the sdk

Comment thread openml/_api/resources/runs.py Outdated
Comment thread openml/_api/resources/runs.py Outdated
Comment thread openml/_api/resources/runs.py Outdated
Comment thread openml/runs/functions.py Outdated
@Omswastik-11 Omswastik-11 requested a review from geetu040 January 30, 2026 09:50
@Omswastik-11 Omswastik-11 marked this pull request as ready for review January 30, 2026 09:50
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Comment thread openml/runs/functions.py Outdated
Comment on lines +822 to +828
use_cache = not ignore_cache
reset_cache = ignore_cache
return api_context.backend.runs.get(
run_id,
use_cache=use_cache,
reset_cache=reset_cache,
)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use_cache should be true since the method always supports caching
reset_cache should rely on ignore_cache

@geetu040
Copy link
Copy Markdown
Collaborator

@Omswastik-11 could you go through the above comments, we'd need to close these discussions.

Copilot AI review requested due to automatic review settings May 22, 2026 12:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

openml/runs/run.py:373

  • The ObjectNotPublishedError message here diverges from the established tagging error message used by OpenMLBase.remove_tag (via openml.utils._tag_openml_base), and it also drops the object context. Consider reusing the same wording/format for consistency across entity types.
        if self.run_id is None:
            raise openml.exceptions.ObjectNotPublishedError(
                "Cannot untag a run that has not been published yet."
                " Please publish the run first before being able to untag it.",
            )

Comment thread openml/_api/resources/base/resources.py
Comment thread tests/test_api/test_run.py Outdated
Comment thread openml/runs/run.py
Comment thread openml/_api/clients/http.py Outdated
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Copilot AI review requested due to automatic review settings May 22, 2026 13:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.

Comment thread openml/_api/resources/base/resources.py
Comment thread openml/_api/resources/run.py Outdated
Comment thread openml/_api/clients/http.py Outdated
Comment thread openml/_api/clients/http.py
Comment thread tests/test_api/test_run.py Outdated
Copilot AI review requested due to automatic review settings May 22, 2026 13:32
@Omswastik-11 Omswastik-11 requested a review from PGijsbers May 22, 2026 13:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Comment thread openml/_api/clients/http.py
Comment thread tests/test_api/test_run.py Outdated
Comment on lines +32 to +38
def test_run_v1_get(run_v1, with_test_cache):
import os

# Run 1 exists on the remote test server; the local docker server only seeds run 25.
run_id = 25 if os.getenv("OPENML_USE_LOCAL_SERVICES") == "true" else 1
run = run_v1.get(run_id=run_id)
_assert_run_shape(run)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll use cached run instead, so this can be ignored

Comment thread tests/test_api/test_run.py
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] V1 → V2 API Migration - runs

9 participants