[ENH] V1 → V2 API Migration - evaluations

[EmanAbdelhaleem]

Depends on #1576
Related to #1575

Details

This PR implements Evaluations resource, and refactor its existing functions

[fkiraly]

looks like circular imports

[EmanAbdelhaleem]

@geetu040 We have circular imports here cuz of importing OpenMLEvaluation

Error message:

  File "D:\Work\ESoC\Developing\openML\openml-python\scripts\reproduce_issues.py", line 1, in <module>
    import openml
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\__init__.py", line 21, in <module>
    from . import (
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\evaluations\__init__.py", line 3, in <module>
    from .evaluation import OpenMLEvaluation
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\evaluations\evaluation.py", line 7, in <module>
    import openml.runs
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\runs\__init__.py", line 3, in <module>
    from .functions import (
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\runs\functions.py", line 32, in <module>
    from openml.tasks import (
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\tasks\__init__.py", line 3, in <module>
    from .functions import (
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\tasks\functions.py", line 15, in <module>
    from openml._api import api_context
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\_api\__init__.py", line 1, in <module>
    from openml._api.runtime.core import APIContext
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\_api\runtime\core.py", line 10, in <module>
    from openml._api.resources import (
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\_api\resources\__init__.py", line 2, in <module>
    from openml._api.resources.evaluations import EvaluationsV1, EvaluationsV2
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\_api\resources\evaluations.py", line 8, in <module>        
    from openml.evaluations.evaluation import OpenMLEvaluation
ImportError: cannot import name 'OpenMLEvaluation' from partially initialized module 'openml.evaluations.evaluation' (most likely due to a circular import) (D:\Work\ESoC\Developing\openML\openml-python\openml\evaluations\evaluation.py)```

[geetu040]

Please update the listing functionality with the suggested approach in #1575 (comment). And also sync this PR with my base PR.

[geetu040]

@geetu040 We have circular imports here cuz of importing OpenMLEvaluation

I don't really have an explanation for why this could be happening, can you try to sync with my branch and see if it persists and we can have a look, otherwise I am going to refactor the config part so it may automatically fix this.

[EmanAbdelhaleem]

Please update the listing functionality with the suggested approach in #1575 (comment). And also sync this PR with my base PR.

Updated, please check

[geetu040]

Looks good overall, should be fine with few changes as suggested. And some comments are open for discussion.

[geetu040]

I am a bit skeptical with this

1. this is a different resource, it should not be coupled with Evaluations
2. it raises the question of inter-resource communication. Can we do that without running into circular-imports? How do we do that, should we use api_context or rely to a utility function in users/functions?
3. is this resource, user used elsewhere in code?
4. is this type of inter-resource communication happening elsewhere in code?

[geetu040]

I suspect you didn't completely remove this and replace with api_context.backend.evaluations.list in partial because of the circular import error? As discussed in the standup, I think the api_context.backend.evaluations.list should return OpenMLEvaluation object, so best comply with both v1/v2 interface.

[geetu040]

please sync this with my pr, this file should not be changed