8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout

[tkiriyama]

Hi All,

JDK-8237834 is being backported from JDK 15 to JDK 8 to resolve instability and test failures in the JDK's LDAP DNS provider test. The issue stems from indefinite waits for LDAP responses when tests connect to unintended services on hardcoded localhost ports. The fix introduces a retry mechanism using different random ports until a "connection refused" error is received, and improves logging for better diagnostic insights, ultimately enhancing test robustness by preventing intermittent failures.

Additionally, this backport is equivalent to the fix applied in JDK 11 except with the @module annotation. This equivalence ensures consistency and demonstrates that the adjustments are robust and have been previously validated on other versions.

Would anyone review this fix?

Thank you.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8237834 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout (Bug - P3 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/756/head:pull/756
$ git checkout pull/756

Update a local copy of the PR:
$ git checkout pull/756
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 756

View PR using the GUI difftool:
$ git pr show -t 756

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/756.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tkiriyama This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 829387f: 8347911: Limit the length of inflated text chunks
• b647fb8: 8375063: Update Libpng to 1.6.54
• d043a24: 8274893: Update java.desktop classes to use try-with-resources
• ... and 6 more: https://git.openjdk.org/jdk8u-dev/compare/bb4e06b88d3c07cc18a02ebeec64b71ea17cfc11...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (7bd671e1)
• 00: Full (d3a66821)

[tkiriyama]

I'd be happy if someone could review this fix.

[jerboaa]

This looks fine, but differs from the JDK 11u version slightly. Why?

See: openjdk/jdk11u-dev@995d620#diff-02ac29783c37146af717f312ff9c3810e47c6794034aa09a4e00baed3bac84e9R258

[jerboaa]

Looks good.

[openjdk]

⚠️ @tkiriyama This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[tkiriyama]

/approval request I would like to backport this bug fix(JDK-8237834) done in jdk15 to jdk8. This fix is equivalent to the successful JDK 11 backport, ensuring reliability. The risk associated with this change is low given that it is solely a test fix.

[openjdk]

@tkiriyama
8237834: The approval request has been created successfully.

[tkiriyama]

/integrate

[openjdk]

@tkiriyama
Your change (at version 7bd671e) is now ready to be sponsored by a Committer.