8313083: Print 'rss' and 'cache' as part of the container information

[jmtd]

Low risk, Oracle parity. Improves diagnostic output. Includes test modifications to cover the new diagnostics.

Included test hotspot/test/runtime/containers/docker/TestMisc.java passes for me.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8313083 needs maintainer approval

Issue

• JDK-8313083: Print 'rss' and 'cache' as part of the container information (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/726/head:pull/726
$ git checkout pull/726

Update a local copy of the PR:
$ git checkout pull/726
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 726

View PR using the GUI difftool:
$ git pr show -t 726

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/726.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into pr/725 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[jmtd]

hotspot/test/runtime/containers/docker/TestMisc.java failing for me at the moment. Investigating... (edit: resolved)

[mlbridge]

Webrevs

• 02: Full - Incremental (292d2f79)
• 01: Full - Incremental (0be5b9f2)
• 00: Full (0be5b9f2)

[bridgekeeper]

@jmtd This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jmtd]

/touch waiting on dependent backports first

[openjdk]

@jmtd The pull request is being re-evaluated and the inactivity timeout has been reset.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8313083-8u
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[jmtd]

tier1 hotspot test failure : gc/arguments/TestCMSHeapSizeFlags.java. will look closer

[jerboaa]

tier1 hotspot test failure : gc/arguments/TestCMSHeapSizeFlags.java. will look closer

We see test failures of that on 32bit Linux every once in a while. Nothing new.

[jerboaa]

@jmtd There seems to be a problem with this functionality. I believe it's related to a missing backport of JDK-8298730. The symptom is something like this in TestMisc.java test logs:

Type %lu not found in file /sys/fs/cgroup/memory/memory.stat

This likely because after this patch we look for rss <value> in /sys/fs/cgroup/memory/memory.stat file. However there are also entries with rss_huge, total_rss, total_rss_huge in memory.stat on some systems. The match function is wrong as it gets a match of > 1, entering the error case. This affects JDK 11u as well. Couldn't reproduce with JDK 17+ Please take a look for JDK 8 and 11. Thank you!

[jmtd]

Hi @jerboaa , I started work on a backport of JDK-8298730 to 11u (openjdk/jdk11u-dev#3149), but it needs a little more work before I can properly request review.