Remove undefined terms in parameterGroup examples#204
Remove undefined terms in parameterGroup examples#204chris-little wants to merge 10 commits intomasterfrom
Conversation
|
Hi @chris-little, thanks for doing this. Having thought about it, I'm wondering if we should just remove the section about statistical measures altogether for now. There's a lot of stuff that would need defining, even in the new simplified version. How about simply including some placeholder text, e.g. "ParameterGroups can also be used to gather related statistical quantities, but this will be defined in a future version of the spec"? |
|
This looks OK as far as I can tell but would benefit from a review from someone who's more familiar with how to insert new vocabularies via the JSON-LD context - perhaps @KathiSchleidt? |
link to archived version of UncertML website (closed in 2016)
Reliable reference for statistical Measures found
|
I'm fine with the hack of referencing eurostat glossary terms, but don't understand why you removed the |
|
On
I left various comments in the file |
|
@KathiSchleidt > I'm fine with the hack of referencing eurostat glossary terms, but don't understand why you removed the The PR was to remove undefined terms in response to your Issue #194 . It is only an example. It is not normative. Do you have a reliable source definition of |
Corrected my mental glitch, thank you @kschleidt
improved English
Simplified example
|
@jonblower @letmaik This is a tidy up of examples so that they work, and point to resolvable meaningful resources. And fix my mental glitch. |
|
@jonblower Have you time for a review? @KathiSchleidt has corrected the JSON-LD syntax. Parameter Group examples simplified and fully resolvable. |
Added missing reference to Eurostat in JSONLD section example
|
@chris-little just wanted to draw attention to my review comment. Do we need the extra example (lines 978 and onwards?) This seems to mainly be a copy of the same example from earlier in the spec. (Also it would be good to tidy up the formatting/indentation.) |
|
@ghobona @gbuehler Have we just found a Metanorma bug? I have no idea what |
|
@chris-little The standard / document.adoc builds fine for me. What specifically are you seeing? As for LutaML, see: https://www.metanorma.org/author/topics/automation/lutaml_uml/ |
|
As this is my Pull Request, I need at least one last review from @jonblower , @KathiSchleidt or @ghobona . Then we can find out if there is still a problem with the Metanorma LutAML issue. If may be an authorisation issues, which perhaps is why @gbuehler does not see it. And to answer @jonblower 's question: the example at line 978 is explained, and slightly different from the previous examples, |
| "statisticalMeasure": "http://www.uncertml.org/statistics/mean", | ||
| "statisticalPeriod": "P1D", | ||
| "narrowerThan": ["http://vocab.nerc.ac.uk/standard_name/sea_surface_temperature/"] | ||
| "statisticalMeasure": "https://ec.europa.eu/eurostat/statistics-explained/index.php?title=Glossary:Arithmetic_mean", |
There was a problem hiding this comment.
Formatting issue - indentation should be fixed on these additions (and below too)
| ``` | ||
|
|
||
| In this example, additional semantics for the registered `dct` prefix are provided by stating that the `"dct:license"` member value in this document is an identifier and not just an unstructured string. | ||
| Example: |
There was a problem hiding this comment.
Do we need this extra example? We already have similar material in the ParameterGroup section
Removed undefined terms
narrowerThan,statisticalMeasureandstatisticalPeriodfrom the Parameter Group examples. Add another example to the JSON-LD section.