Open
Conversation
kernicPanel
reviewed
Apr 25, 2025
ptitloup
force-pushed
the
ptitloup/improve_test_orders_refund
branch
3 times, most recently
from
994dbb7 to
5c28b4c
Compare
kernicPanel
reviewed
Apr 29, 2025
Member
kernicPanel
left a comment
kernicPanel
left a comment
There was a problem hiding this comment.
The commit message is still wrong.
Member
|
The commit message should not exceed 80 characters long. |
added 2 commits
May 9, 2025 15:50
Fix a failing flaky unit test on refund an order when its state is canceled. Once a refund is requested an email should be sent to notify the user. The content email based on mjml templates and the footer part use a variable to fill the catalog base url. None as default, we override it with the override_settings before function definition to check its value.
After my first commit of ma contribution, my dear collegue show me how to improve the linting of a string. Due to the awesome circle ci, I have to write a long text to explain why I just add a double quote and a return line. It's wonderful !
ptitloup
force-pushed
the
ptitloup/improve_test_orders_refund
branch
from
d362210 to
b1f12c7
Compare
kernicPanel
reviewed
May 12, 2025
Member
kernicPanel
left a comment
kernicPanel
left a comment
There was a problem hiding this comment.
-
There should be only one commit here.
-
Also, there something strange with your commits there is 2 authors:
-
Please don't use tags on pull requests titles
Member
|
IMHO, you should try merge the 2 first commits together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
override settings before test to add joanie catalog base url and use it in footer mail template