Adds Clearwater Lakes map : conjoined circles map#4716
Conversation
WalkthroughAdds the Clearwater Lakes map with metadata, regional country definitions, map assets, English localization, and generated registry entries. ChangesClearwater Lakes map
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@resources/countries.json`:
- Around line 145-149: Update every newly added country object in
resources/countries.json, including the entries identified at the referenced
locations, to explicitly include the "restricted" field set to false. Ensure
each affected entry remains valid JSON and follows the existing country-entry
property structure.
In `@src/core/game/Maps.gen.ts`:
- Line 34: Update the existing generic map-registry/schema test to discover and
validate every generated map entry, including ClearwaterLakes, without adding a
map-specific assertion. Keep the coverage data-driven so future entries are
validated automatically.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 252f6967-6508-4817-bd5e-5b35f8a52a07
⛔ Files ignored due to path filters (10)
map-generator/assets/maps/clearwaterlakes/image.pngis excluded by!**/*.pngresources/flags/Anishinaabe.svgis excluded by!**/*.svgresources/flags/Inuvialuit.svgis excluded by!**/*.svgresources/flags/Metis.svgis excluded by!**/*.svgresources/flags/Mi'kmaq.svgis excluded by!**/*.svgresources/flags/Natuaqanek.svgis excluded by!**/*.svgresources/flags/Nunavik.svgis excluded by!**/*.svgresources/maps/clearwaterlakes/map.binis excluded by!**/*.binresources/maps/clearwaterlakes/map16x.binis excluded by!**/*.binresources/maps/clearwaterlakes/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (6)
map-generator/assets/maps/clearwaterlakes/info.jsonresources/countries.jsonresources/lang/en.jsonresources/maps/clearwaterlakes/manifest.jsonresources/maps/clearwaterlakes/thumbnail.webpsrc/core/game/Maps.gen.ts
Description:
More fun impassable-centric maps: Clearwater Lakes: https://en.wikipedia.org/wiki/Clearwater_Lakes in Northern Quebec
A map made of 2 circles , the borders are shape while the center of these circles are lakes. Fun linear map with a chokepoint in the middle and multiple islands for players who enjoy island and pirate plays.
This is an obscure location, so i gave it rotation of 3.
clearwaters.mp4
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tri.star1011