Adds "New" tag to new map Branching Paths#4695
Conversation
Should resolve issue openfrontio#4668 once it is given the green light
…Branching Paths. Should properly fix issue openfrontio#4668 now.
WalkthroughBranchingPaths now has the ChangesBranchingPaths metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/core/game/Maps.gen.ts`:
- Line 329: Add or update a metadata test covering the generated map entry’s
categories, including "new", and verify the map-picker category pipeline
recognizes and exposes it. Keep the test focused on the relevant map metadata
and follow existing test patterns for src/core changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9358ba94-8cde-4b4d-97a2-d069ea735dc1
📒 Files selected for processing (3)
map-generator/assets/maps/branchingpaths/info.jsonresources/maps/branchingpaths/manifest.jsonsrc/core/game/Maps.gen.ts
| type: GameMapType.BranchingPaths, | ||
| translationKey: "map.branchingpaths", | ||
| categories: ["arcade", "fictional"], | ||
| categories: ["arcade", "fictional", "new"], |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add a test for the generated map metadata change.
The "new" category is correctly wired, but this src/core/ change has no accompanying test in the supplied PR. Add or update a metadata test that validates recognized map categories and the map-picker category pipeline.
As per coding guidelines, all changes to src/core/ must include tests.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/core/game/Maps.gen.ts` at line 329, Add or update a metadata test
covering the generated map entry’s categories, including "new", and verify the
map-picker category pipeline recognizes and exposes it. Keep the test focused on
the relevant map metadata and follow existing test patterns for src/core
changes.
Source: Coding guidelines
Fixes issue #4668 by properly adding the "new" tag to the map Branching Paths, should display properly now when looking through the map lists.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
TheGamingFish