Skip to content

Adds "New" tag to new map Branching Paths#4695

Merged
evanpelle merged 2 commits into
openfrontio:mainfrom
NotRocketfish:main
Jul 23, 2026
Merged

Adds "New" tag to new map Branching Paths#4695
evanpelle merged 2 commits into
openfrontio:mainfrom
NotRocketfish:main

Conversation

@NotRocketfish

Copy link
Copy Markdown
Contributor

Fixes issue #4668 by properly adding the "new" tag to the map Branching Paths, should display properly now when looking through the map lists.

Screenshot 2026-07-23 162859

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

TheGamingFish

Should resolve issue openfrontio#4668 once it is given the green light
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

BranchingPaths now has the "new" category in its source metadata, resource manifest, and generated map metadata.

Changes

BranchingPaths metadata

Layer / File(s) Summary
Add the new map category
map-generator/assets/maps/branchingpaths/info.json, resources/maps/branchingpaths/manifest.json, src/core/game/Maps.gen.ts
The BranchingPaths categories arrays now include "new" alongside the existing categories.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: Maps

Suggested reviewers: rickd004, evanpelle

Poem

Branching paths now wear a tag,
“new” joins the map’s small flag.
Source and manifest match in tune,
Generated data follows soon.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: adding the new tag to the Branching Paths map.
Description check ✅ Passed The description is directly related to the change and explains the issue fix and UI effect.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the small-fix Small fix (≤ 50 lines) — auto-applied by PR gate label Jul 23, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/core/game/Maps.gen.ts`:
- Line 329: Add or update a metadata test covering the generated map entry’s
categories, including "new", and verify the map-picker category pipeline
recognizes and exposes it. Keep the test focused on the relevant map metadata
and follow existing test patterns for src/core changes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9358ba94-8cde-4b4d-97a2-d069ea735dc1

📥 Commits

Reviewing files that changed from the base of the PR and between 741ab0f and 181caac.

📒 Files selected for processing (3)
  • map-generator/assets/maps/branchingpaths/info.json
  • resources/maps/branchingpaths/manifest.json
  • src/core/game/Maps.gen.ts

Comment thread src/core/game/Maps.gen.ts
type: GameMapType.BranchingPaths,
translationKey: "map.branchingpaths",
categories: ["arcade", "fictional"],
categories: ["arcade", "fictional", "new"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add a test for the generated map metadata change.

The "new" category is correctly wired, but this src/core/ change has no accompanying test in the supplied PR. Add or update a metadata test that validates recognized map categories and the map-picker category pipeline.

As per coding guidelines, all changes to src/core/ must include tests.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/core/game/Maps.gen.ts` at line 329, Add or update a metadata test
covering the generated map entry’s categories, including "new", and verify the
map-picker category pipeline recognizes and exposes it. Keep the test focused on
the relevant map metadata and follow existing test patterns for src/core
changes.

Source: Coding guidelines

@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Jul 23, 2026
@evanpelle evanpelle added this to the v33 milestone Jul 23, 2026
@evanpelle
evanpelle merged commit df463a7 into openfrontio:main Jul 23, 2026
11 of 12 checks passed
@github-project-automation github-project-automation Bot moved this from Development to Complete in OpenFront Release Management Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small-fix Small fix (≤ 50 lines) — auto-applied by PR gate

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants