Skip to content

Adds Balkhash map: Pipe map#4682

Open
RickD004 wants to merge 2 commits into
openfrontio:mainfrom
RickD004:balkhash
Open

Adds Balkhash map: Pipe map#4682
RickD004 wants to merge 2 commits into
openfrontio:mainfrom
RickD004:balkhash

Conversation

@RickD004

@RickD004 RickD004 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description:

High Fidelity use for Impassable Terrain: Lake Balkhash https://en.wikipedia.org/wiki/Lake_Balkhash in Kazakhstan

This map is shaped like a folded pipe, with a 90° curve in the left side, to follow the shape of the lake.
This provides interesting gameplay since players could use the impassable to their advantage, building bases in strategic points where certain enemies cannot hit them with bombs thanks to said terrain.

Various towns and cities from the area as nations. Also historical entities as additional nations with their own new flags

Captura de pantalla 2026-07-22 220016 Captura de pantalla 2026-07-23 020947 Captura de pantalla 2026-07-23 021318

Please complete the following:

  • I have added screenshots for all UI updates
  • [x[ I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME

@RickD004
RickD004 requested a review from a team as a code owner July 23, 2026 08:26
@RickD004 RickD004 added the Maps A new map, or adjustments to an existing map itself, its json, etc, label Jul 23, 2026
@RickD004 RickD004 added this to the v33 milestone Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 90170bdb-2ae1-4152-b95c-077198dd90df

📥 Commits

Reviewing files that changed from the base of the PR and between 086e906 and 41c6bb1.

📒 Files selected for processing (3)
  • resources/countries.json
  • resources/lang/en.json
  • src/core/game/Maps.gen.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • resources/lang/en.json
  • resources/countries.json
  • src/core/game/Maps.gen.ts

Walkthrough

Adds the Balkhash map end to end: historical nation records, source and runtime metadata, map dimensions and placements, localization, thumbnail artwork, and game registry entries.

Changes

Balkhash map

Layer / File(s) Summary
Historical nation catalog
resources/countries.json
Adds nine historical country and region records used by the map.
Map metadata and assets
map-generator/assets/maps/balkhash/info.json, resources/maps/balkhash/manifest.json, resources/lang/en.json, resources/maps/balkhash/thumbnail.webp
Defines Balkhash metadata, dimensions, nation placements, additional nations, English localization, and thumbnail artwork.
Game map registration
src/core/game/Maps.gen.ts
Adds the Balkhash map type and its exported registry entry.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant MapSource
  participant MapManifest
  participant GameRegistry
  participant Localization
  MapSource->>MapManifest: provide Balkhash metadata and nation placements
  MapManifest->>GameRegistry: register map dimensions and nations
  GameRegistry->>Localization: resolve map.balkhash
Loading

Possibly related PRs

Suggested reviewers: evanpelle

Poem

Balkhash arrives with flags held high,
Nations gather beneath its sky.
Coordinates settle, names align,
A thumbnail glows in WebP shine.
The map registry makes room—
A new adventure starts to bloom.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and matches the main change: adding the Balkhash map with its pipe-like shape.
Description check ✅ Passed The description clearly matches the changeset by explaining the Balkhash map, its terrain shape, and added nations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/core/game/Maps.gen.ts`:
- Line 20: Add or update the src/core registry test for GameMapType.Balkhash to
verify its entry uses the name "Balkhash", identifier "map.balkhash", categories
["new", "asia"], and frequency 4, covering both the new enum value and registry
mapping.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c6343ba-0bde-4909-b337-b9dd9ee7a520

📥 Commits

Reviewing files that changed from the base of the PR and between d76a0c4 and 086e906.

⛔ Files ignored due to path filters (13)
  • map-generator/assets/maps/balkhash/image.png is excluded by !**/*.png
  • resources/flags/Alash Autonomy.svg is excluded by !**/*.svg
  • resources/flags/Bukhara.svg is excluded by !**/*.svg
  • resources/flags/Golden Horde.svg is excluded by !**/*.svg
  • resources/flags/Göktürks Khaganate.svg is excluded by !**/*.svg
  • resources/flags/Kazakh Khanate.svg is excluded by !**/*.svg
  • resources/flags/Khiva.svg is excluded by !**/*.svg
  • resources/flags/Timurid Empire.svg is excluded by !**/*.svg
  • resources/flags/Turkestan Autonomy.svg is excluded by !**/*.svg
  • resources/flags/Turkestan.svg is excluded by !**/*.svg
  • resources/maps/balkhash/map.bin is excluded by !**/*.bin
  • resources/maps/balkhash/map16x.bin is excluded by !**/*.bin
  • resources/maps/balkhash/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (6)
  • map-generator/assets/maps/balkhash/info.json
  • resources/countries.json
  • resources/lang/en.json
  • resources/maps/balkhash/manifest.json
  • resources/maps/balkhash/thumbnail.webp
  • src/core/game/Maps.gen.ts

Comment thread src/core/game/Maps.gen.ts
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maps A new map, or adjustments to an existing map itself, its json, etc,

Projects

Status: Development

Development

Successfully merging this pull request may close these issues.

1 participant