Repository navigation
Add the missing addons.make to three examples - #8596
Merged
danoli3 merged 1 commit intoOct 22, 2026
Merged
Conversation
svgParseExample and svgSaveExample include ofxSvg.h and yunetFaceDetection includes ofxOpenCv.h, but none of them has an addons.make, so the makefiles, CMake and projectGenerator don't add the addon and the build fails with 'ofxSvg.h' / 'ofxOpenCv.h' file not found. The root .gitignore ignores examples/**/addons.make, so they were left out when the examples were added (openframeworks#8266, openframeworks#8484).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
svgParseExampleandsvgSaveExampleincludeofxSvg.h, andyunetFaceDetectionincludesofxOpenCv.h. None of the three has anaddons.make, so the makefiles, CMake and projectGenerator don't add the addon, and the build fails:The root
.gitignoreignoresexamples/**/addons.make(the other 75 are force-added), so these were missed when the examples were added in #8266 and #8484. This adds them withgit add -f:input_output/svgParseExampleofxSvginput_output/svgSaveExampleofxSvgcomputer_vision/yunetFaceDetectionofxOpenCvFound while building every example with CMake (#8586) on macOS: 154 of 157 built, and with these files all 157 do.