Repository navigation
Conversation
bzero is POSIX-only and isn't available with MSVC. memset (from <cstring>) clears the matrix the same way on every platform. From openframeworks#7524. Co-authored-by: Dan Rosser <danoli3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ofxAccelerometer.hclears its rotation matrix withbzero, which is POSIX-only and doesn't exist with MSVC. This switches it tomemset(matrix, 0, sizeof(matrix))and includes<cstring>. The behaviour is the same on every platform.The change is @HerrNamenlos123's, from the CMake PR #7524 (still open, so it's split out here on its own). The commit is authored by them.
Checked:
ofxAccelerometer.hcompiles (clang++ -std=c++20 -fsyntax-only) with a small file that callsofxAccelerometer.setup().