Skip to content

chore : Remove set_code_owner_attribute decorator from various Celery tasks - #38967

Open
ktyagiapphelix2u wants to merge 2 commits into
openedx:masterfrom
ktyagiapphelix2u:ktyagi/BOMS-241
Open

chore : Remove set_code_owner_attribute decorator from various Celery tasks#38967
ktyagiapphelix2u wants to merge 2 commits into
openedx:masterfrom
ktyagiapphelix2u:ktyagi/BOMS-241

Conversation

@ktyagiapphelix2u

Copy link
Copy Markdown
Contributor

Summary

This PR removes the @set_code_owner_attribute decorator from multiple Celery tasks across different modules. The changes aim to clean up the codebase by eliminating unnecessary monitoring attributes that are no longer required. The affected files include tasks related to course overviews, search, content libraries, content staging, tagging, user authentication, notifications, and more.

Additionally, the semgrep configuration files related to code ownership checks have been deleted as they are no longer applicable.

Ticket

https://2u-internal.atlassian.net/browse/BOMS-241

@robrap robrap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR could be merged if we get through review. Removing uses is not blocked. Removing the definition is blocked (see ticket).



@shared_task(base=CourseImportTask, bind=True)
# Note: The decorator @set_code_owner_attribute cannot be used here because the UserTaskMixin

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like it was carefully reviewed internally, so I'll stop here for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants