Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/odr/internal/iwork/iwork_document.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ class ElementAdapter final : public abstract::ElementAdapter,
.print_orientation = {},
.margin = {},
.background_color = {},
.direction = {},
};
}
[[nodiscard]] ElementIdentifier slide_master_page(
Expand Down
2 changes: 2 additions & 0 deletions src/odr/internal/oldms/presentation/ppt_document.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ class ElementAdapter final : public abstract::ElementAdapter,
.print_orientation = {},
.margin = {},
.background_color = {},
.direction = {},
};
}
return {
Expand All @@ -155,6 +156,7 @@ class ElementAdapter final : public abstract::ElementAdapter,
.print_orientation = {},
.margin = {},
.background_color = {},
.direction = {},
};
}
[[nodiscard]] ElementIdentifier slide_master_page(
Expand Down
7 changes: 5 additions & 2 deletions test/src/internal/odf/odf_flat_file_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -587,10 +587,13 @@ TEST(FlatOpenDocumentFile, a_right_to_left_writing_mode_reads_as_a_direction) {
/// Neither is a left-to-right claim.
TEST(FlatOpenDocumentFile, a_writing_mode_without_a_side_names_no_direction) {
for (const char *mode : {"tb-rl", "tb-lr", "tb", "page"}) {
// built outside the macro: msvc's traditional preprocessor does not read
// a raw string in a macro argument, and trips over the quotes inside it
const std::string properties =
R"(style:writing-mode=")" + std::string(mode) + R"(")";
EXPECT_EQ(std::vector<std::optional<TextDirection>>(
{std::nullopt, std::nullopt, std::nullopt}),
directions_of(three_paragraphs(
"P1", R"(style:writing-mode=")" + std::string(mode) + "\"")))
directions_of(three_paragraphs("P1", properties)))
<< mode;
}
}
Expand Down
Loading