Merged
Conversation
…n a model has been loaded. We need to use `v-if` rather than `v-show` otherwise when we have several instances of OpenCOR with the `omex` prop then once the first instance has loaded its model, its `Loading model...` message will remain visible until the second instance has loaded its model, etc.
There was a problem hiding this comment.
Pull request overview
Updates the renderer to better reflect long-running operations (model/external data loading), aligns external CSV parsing calls, and bumps build/runtime dependencies while updating how libOpenCOR WASM is loaded.
Changes:
- Add a dedicated “Loading external data…” blocking message and include it in UI blocking conditions.
- Fix external CSV parsing call site to use the
externalDatanamespace consistently. - Update libOpenCOR WASM loading to use a versioned path and provide a
locateFilehandler for the.wasm, plus bump app/dependency versions (Electron/Vite, lockfiles).
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/components/OpenCOR.vue | Adds external-data loading overlay/state and adjusts model loading overlay rendering. |
| src/renderer/src/components/dialogs/SimulationExperimentViewSettingsDialog.vue | Fixes CSV parsing invocation to externalData.parseExternalCsvData(...). |
| src/renderer/src/common/initialisation.ts | Switches libOpenCOR to a versioned WASM URL and configures locateFile for the .wasm. |
| src/renderer/package.json | Bumps renderer package version and Vite dependency. |
| src/renderer/bun.lock | Lockfile updates for renderer dependency bumps. |
| package.json | Bumps root package version; updates Electron and Vite. |
| bun.lock | Lockfile updates for root dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…to `parseExternalCsvData()` with a call to `externalData.parseExternalCsvData()`.
… some online external data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.