Add TelemetryCheck for static_arp_test

[RishabhAgarwal-2001]

I have updated the static_arp_test to add an extra sub-test that verifies the correctness of the MAC values configured.

Since the state paths are not supported for Cisco devices, I have added a deviation to use Functional Translator for the case of Cisco.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the static_arp_test by incorporating a new telemetry check to validate the accuracy of MAC addresses configured for static ARP entries. It also includes a platform-specific adjustment for Cisco devices, enabling the use of a Functional Translator for ARP to ensure test compatibility and correct behavior where standard state paths are not available.

Highlights

• New Telemetry Check: Added a new sub-test named TelemetryCheck to static_arp_test to verify the correctness of configured MAC values for both IPv4 and IPv6 neighbors.
• Cisco ARP Deviation: Introduced a deviation for Cisco devices to use a Functional Translator for ARP, addressing the lack of direct state path support for neighbor link-layer addresses on these platforms.

Changelog

• feature/interface/staticarp/otg_tests/static_arp_test/metadata.textproto
  • Added a new arp_ft deviation entry for Cisco XR.
• feature/interface/staticarp/otg_tests/static_arp_test/static_arp_test.go
  • Implemented a new sub-test TelemetryCheck to verify MAC addresses for IPv4 and IPv6 neighbors.
  • Utilized the ArpFT deviation to fetch functional translator options for Cisco devices.
• internal/deviations/deviations.go
  • Added a new ArpFT function to retrieve the functional translator name for ARP deviations.
• proto/metadata.proto
  • Defined a new arp_ft field (ID 392) within the Metadata_Deviations message.
• proto/metadata_go_proto/metadata.pb.go
  • Updated the Metadata_Deviations struct to include the ArpFt field.
  • Added the GetArpFt method to access the new deviation field.
  • Adjusted the file_metadata_proto_rawDesc constant to reflect the schema changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5227 / b4448bb

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TE-1.1: Static ARP	0f874c1c	Log
Cisco 8000E		TE-1.1: Static ARP	604396fd	Log
Cisco XRd		TE-1.1: Static ARP	9da58f6d	Log
Juniper ncPTX		TE-1.1: Static ARP	93263e5e	Log
Nokia SR Linux		TE-1.1: Static ARP	5d8b9ffa	Log
Openconfig Lemming		TE-1.1: Static ARP	3b6f070e	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		TE-1.1: Static ARP
Cisco 8808		TE-1.1: Static ARP
Juniper PTX10008		TE-1.1: Static ARP
Nokia 7250 IXR-10e		TE-1.1: Static ARP

Help

[gemini-code-assist]

Code Review

This pull request adds a telemetry check for the static ARP test, introducing a new deviation for Cisco devices. My review focuses on improving the test structure and ensuring adherence to the repository's deviation guidelines.

I've suggested refactoring the new test to use a table-driven approach for better readability and maintainability, as recommended by the style guide. Additionally, I've pointed out that the new deviation accessor function is missing the required issue tracker URL in its comment, which is a requirement from the contribution guidelines.

[RishabhAgarwal-2001]

The failing FNT Gap Analysis check predates this change and does not fail because of changes made in this PR.

[AmrNJ]

LGTM.