Skip to content

Support Qos Map on Router Interface#2208

Merged
tjchadaga merged 1 commit intoopencomputeproject:masterfrom
komal-marvell:rif_qos_map
Mar 12, 2026
Merged

Support Qos Map on Router Interface#2208
tjchadaga merged 1 commit intoopencomputeproject:masterfrom
komal-marvell:rif_qos_map

Conversation

@komal-marvell
Copy link
Copy Markdown
Contributor

@komal-marvell komal-marvell commented Sep 17, 2025 •
edited
Loading

Qos map can be assigned to Router interface for Ingress mapping and Egress marking for DSCP and DOT1P

@eddyk-nvidia
Copy link
Copy Markdown

eddyk-nvidia commented Sep 19, 2025

As discussed during the community review please add some information about expected precedence order in case of mapping configured at different objects. Or it can be vendor specific ?

@tjchadaga tjchadaga added the reviewed PR is discussed in SAI Meeting label Sep 22, 2025
@tjchadaga
Copy link
Copy Markdown
Collaborator

tjchadaga commented Oct 7, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Copy Markdown
Collaborator

tjchadaga commented Oct 7, 2025

@komal-marvell - could you please help address the comment?

@komal-marvell
Copy link
Copy Markdown
Contributor Author

komal-marvell commented Oct 10, 2025

As discussed during the community review please add some information about expected precedence order in case of mapping configured at different objects. Or it can be vendor specific ?

As discussed in community meeting, updated the PR with the precedence order. Please check in the header comment description.

@tjchadaga
Copy link
Copy Markdown
Collaborator

tjchadaga commented Oct 10, 2025

@eddyk-nvidia - could you please help sign-off on this?

@tjchadaga
Copy link
Copy Markdown
Collaborator

tjchadaga commented Oct 10, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 10, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Copy Markdown
Collaborator

tjchadaga commented Oct 22, 2025

@komal-marvell - please rebase your branch and squash commit to fix failures

@komal-marvell
Support Qos Map on Router Interface
62da084 
Signed-off-by: Komal Shah <kshah2@marvell.com>
@komal-marvell
Copy link
Copy Markdown
Contributor Author

komal-marvell commented Oct 24, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 24, 2025

Commenter does not have sufficient privileges for PR 2208 in repo opencomputeproject/SAI

@tjchadaga
Copy link
Copy Markdown
Collaborator

tjchadaga commented Oct 24, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 24, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Copy Markdown
Collaborator

tjchadaga commented Nov 12, 2025

@eddyk-nvidia - could you please help complete the review?

@tjchadaga
Copy link
Copy Markdown
Collaborator

tjchadaga commented Dec 12, 2025

@eddyk-nvidia - gentle reminder. Please help complete the review

@tjchadaga
Copy link
Copy Markdown
Collaborator

tjchadaga commented Feb 10, 2026

@JaiOCP, @eddyk-nvidia - could you please help sign off on this?

eddyk-nvidia
eddyk-nvidia approved these changes Mar 12, 2026
View reviewed changes
Copy link
Copy Markdown

@eddyk-nvidia eddyk-nvidia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support of these new fields is vendor-specific. So, the code using it should query the platform capability before use

@rck-innovium
Copy link
Copy Markdown
Contributor

rck-innovium commented Mar 12, 2026

Support of there new fields is vendor-specific. So, the code using it should query the platform capability before use

Thanks @eddyk-nvidia. It is always good for applications (including SONiC) to do a capability query before using the new attributes.

Hi @tjchadaga can you please merge this for v1.18

@tjchadaga tjchadaga merged commit a189d93 into opencomputeproject:master Mar 12, 2026
3 checks passed
tjchadaga pushed a commit that referenced this pull request Mar 31, 2026
@komal-marvell @tjchadaga
Support Qos Map on Router Interface (#2208)
ffbb1fe 
Signed-off-by: Komal Shah <kshah2@marvell.com>
cursor Bot pushed a commit to yuriilisovskyi/SAI that referenced this pull request Apr 7, 2026
@komal-marvell @cursoragent
Support Qos Map on Router Interface (opencomputeproject#2208)
20f185a 
Signed-off-by: Komal Shah <kshah2@marvell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjchadaga tjchadaga tjchadaga approved these changes

+2 more reviewers

@vmittal-msft vmittal-msft vmittal-msft approved these changes

@eddyk-nvidia eddyk-nvidia eddyk-nvidia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

reviewed PR is discussed in SAI Meeting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@komal-marvell @eddyk-nvidia @tjchadaga @rck-innovium @vmittal-msft