Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the notification cue system for inbox events by introducing a new, more distinctive "bing" sound, synchronizing notification preferences across tabs and components, and displaying a badge for unread inbox messages in the sidebar. It also sets sound notifications to be enabled by default and adds robust event broadcasting and listening for preference changes.
Notification sound improvements:
playInboxBingSoundfunction that plays a two-tone "bing" sound, implemented in a new utility (playInboxBingSound.ts), and updates all relevant components to use this function instead of the previous inline implementation. [1] [2] [3] [4]Notification preferences synchronization:
INBOX_CUE_PREFERENCES_UPDATED_EVENTevent and abroadcastInboxCuePreferencesUpdatedfunction to broadcast inbox cue preference changes across tabs and components, ensuring all listeners are updated immediately. Components now listen for this event in addition to the storage event. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Sidebar unread badge and notification cues:
Default preferences update:
Testing improvements:
broadcastInboxCuePreferencesUpdatedcorrectly dispatches the custom event for same-tab listeners.