build: use vue-tsc to generate d.ts files for libraries#2194
Open
JammingBen wants to merge 4 commits intomainfrom
Open
build: use vue-tsc to generate d.ts files for libraries#2194JammingBen wants to merge 4 commits intomainfrom
d.ts files for libraries#2194JammingBen wants to merge 4 commits intomainfrom
Conversation
JammingBen
force-pushed
the
chore/vue-tsc-lib-type-generation
branch
from
6b0d164 to
4dd2f15
Compare
JammingBen
changed the title
Removes the `vite-plugin-dts` dependency and uses `vue-tsc` to generate type for our library builds (pkg, client, test-helpers, design-system). This means one dependency less and ensures that we use the same type checking mechanism like Web.
JammingBen
force-pushed
the
chore/vue-tsc-lib-type-generation
branch
2 times, most recently
from
9581348 to
58bae57
Compare
Adds type checks for libraries we build so we can see if emitting `d.ts` files on build would succeed. Also adds them to CI.
JammingBen
force-pushed
the
chore/vue-tsc-lib-type-generation
branch
from
58bae57 to
8e31d7e
Compare
Member
Author
|
@kulmann I included the new library type check in the I'm a bit unsure whether to include it in |
JammingBen
changed the title
d.ts files for libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
vite-plugin-dtsdependency and usesvue-tscto generated.tsfiles for our library builds (pkg, client, test-helpers, design-system). This means one dependency less and ensures that we use the same type checking mechanism like Web.Also adds type checks for libraries we build so we can see if emitting
d.tsfiles on build would succeed.closes #2159
waiting for #2184 to get merged first.