Use favorites from graph api

[pascalwengerter]

Related Issue

• Fixes Favorites status indicator #1341
• Fixes Tiles view: Favorites #1342
• Fixes Toggle favorites #2170

Types of changes

• Enhancement (a change that doesn't break existing code or deployments)
• Breaking change (a modification that affects current functionality), if you consider removing the legacy favorite option "supported" (@kulmann)
• Technical debt (addressing code that needs refactoring or improvements)

[AlexAndBear]

@pascalwengerter started the ci. Type check and linter are complaining

[pascalwengerter]

@pascalwengerter started the ci. Type check and linter are complaining

Thx, will rebase & address

[AlexAndBear]

@pascalwengerter works very good at first glance!

But there is something off with the search, every item is marked as favorite even if they ain't marked as such.

can you also check if its possible to add project spaces as favorites ? I am not sure if there is a backend limitation, but would be great.

[AlexAndBear]

I had a chat with the team. Can you please set the fill type to line in the status indicators, so it machtes the other ones and looks a little more subtle ? 🙏

[pascalwengerter]

Thx for the feedback, will investigate (& adapt the icon). I'm kinda surprised there's no test changes needed/expected failures to update?

[AlexAndBear]

Thx for the feedback, will investigate (& adapt the icon). I'm kinda surprised there's no test changes needed/expected failures to update?

Same, I was expecting there were some disabled e2e tests, but couldn't find any

[AlexAndBear]

is this necessary?

[AlexAndBear]

The reason why the search is showing false positive starred items is in packages/web-client/src/helpers/resource/functions.ts

the check

starred: resource.props[DavProperty.IsFavorite] !== 0

should be changed to

starred:resource.props[DavProperty.IsFavorite] === 1

Unfortunately, the search is not yet compatible with favorites :sigh:

[AlexAndBear]

@pascalwengerter I am baffled. I checked if we can add spaces to favorites and it's supported by the backend. You can add it to space actions if you want to, or I'll do it in a follow-up 👍

[kulmann]

@pascalwengerter I am baffled. I checked if we can add spaces to favorites and it's supported by the backend. You can add it to space actions if you want to, or I'll do it in a follow-up 👍

Ahaha nice, that's a nice addition to the plate ❤️ I wonder if it was by accident. 😅 @aduffeck

[AlexAndBear]

@aduffeck @kulmann

Unfortunately, the /drive(s) endpoint doesn't expose this information; we need to add the flag to unleash the full power of favourites in conjuction with spaces.

I was hoping that we can add the following relation prop and reference the item itself:
https://learn.microsoft.com/en-us/graph/api/resources/drive?view=graph-rest-1.0

"following": [{"@odata.type": "microsoft.graph.driveItem"}]

Otherwise we would need a custom prop.

The REPORT endpoint also doesn't expose if a file is a favourite, which is a blocker

But so far we are making big progress.

Special thanks to @pascalwengerter ⭐️

[pascalwengerter]

@aduffeck @kulmann

Unfortunately, the /drive(s) endpoint doesn't expose this information; we need to add the flag to unleash the full power of favourites in conjuction with spaces.

I was hoping that we can add the following relation prop and reference the item itself: https://learn.microsoft.com/en-us/graph/api/resources/drive?view=graph-rest-1.0

"following": [{"@odata.type": "microsoft.graph.driveItem"}]

Otherwise we would need a custom prop.

The REPORT endpoint also doesn't expose if a file is a favourite, which is a blocker

But so far we are making big progress.

Special thanks to @pascalwengerter ⭐️

Does this warrant an issue in the opencloud repo? And do we need to revert opencloud-eu/opencloud#2494 because favorites aren't fully implemented? 🤔

[AlexAndBear]

@aduffeck @kulmann
Unfortunately, the /drive(s) endpoint doesn't expose this information; we need to add the flag to unleash the full power of favourites in conjuction with spaces.
I was hoping that we can add the following relation prop and reference the item itself: https://learn.microsoft.com/en-us/graph/api/resources/drive?view=graph-rest-1.0
"following": [{"@odata.type": "microsoft.graph.driveItem"}]
Otherwise we would need a custom prop.
The REPORT endpoint also doesn't expose if a file is a favourite, which is a blocker
But so far we are making big progress.
Special thanks to @pascalwengerter ⭐️

Does this warrant an issue in the opencloud repo? And do we need to revert opencloud-eu/opencloud#2494 because favorites aren't fully implemented? 🤔

Depends on how fast the backend moves, the sprint ends this upcoming Friday.
If the blocker is not resolved, a revert is recommended

But @aduffeck is informed, and I think he will handle this just in time (:

[AlexAndBear]

I made the following changes upon yours:

• Fix the favorite false positive state in search
• Changed the icon fill type to line
• Adjusted the no content message
• Added the action to spaces disabled for now
• Added to batch actions
• Added batch actions to favorites page

[pascalwengerter]

@AlexAndBear can/will you take over? Backend update seems to have landed, and not sure how much time I can dedicate to this the following days

[AlexAndBear]

@pascalwengerter Yes 🙌

I asked the team to do the review. Spaces will not yet be supported but later in the upcoming sprint.

Thank you so much 😊

[kulmann]

Wow, nice! 🤩 Thank you @pascalwengerter for contributing this and @AlexAndBear for all your work that went into this PR! ❤️

The only thing I found a bit weird is that the context actions don't close the context menu. I know that we did that on purpose back in the days, but it doesn't feel good (anymore?)... could you please remove that behaviour and just let the context menu close itself when the favorite toggle in the context menu was clicked?

[kulmann]

tempted to propose All your base are belong to us 🙈