Skip to content

next to main#2924

Merged
fschade merged 6 commits into
mainfrom
next
Jun 11, 2026
Merged

next to main#2924
fschade merged 6 commits into
mainfrom
next

Conversation

@kulmann

@kulmann kulmann commented Jun 10, 2026

Copy link
Copy Markdown
Member

No description provided.

Comment thread .gitignore Outdated
Comment thread services/web/Makefile Outdated
Comment thread services/collaboration/pkg/font/service.go
Comment thread services/collaboration/pkg/font/service.go
Comment thread services/collaboration/pkg/notification/service.go
Comment thread services/collaboration/pkg/command/server.go Outdated
Comment thread services/collaboration/pkg/command/server.go Outdated
Comment thread services/proxy/pkg/config/defaults/defaultconfig.go
Comment thread services/proxy/pkg/config/defaults/defaultconfig.go
Comment thread services/notifications/pkg/service/resource.go Outdated
Comment thread services/settings/pkg/store/defaults/permissions.go Outdated
@kulmann kulmann marked this pull request as ready for review June 10, 2026 19:13
@fschade

fschade commented Jun 10, 2026

Copy link
Copy Markdown
Member

@kulmann, should we really enable that by default?

not all installation have collabora enabled, enabling the app can happen using the cfg $OC_ROOT/opencloud.yaml

...
web:
  web:
    config:
      apps:
        - files
        - search
        - text-editor
        - pdf-viewer
        - external
        - admin-settings
        - epub-reader
        - preview
        - app-store
        - office-settings # <-- load the office settings app 

@kulmann

kulmann commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

@kulmann, should we really enable that by default?

not all installation have collabora enabled, enabling the app can happen using the cfg $OC_ROOT/opencloud.yaml

...
web:
  web:
    config:
      apps:
        - files
        - search
        - text-editor
        - pdf-viewer
        - external
        - admin-settings
        - epub-reader
        - preview
        - app-store
        - office-settings # <-- load the office settings app 

true. removed it again... but it's so ugly to enable additional apps :-(

edit: now there is an ugly but easy way: #2930

@opencloud-eu opencloud-eu deleted a comment from codacy-production Bot Jun 11, 2026
@codacy-production

codacy-production Bot commented Jun 11, 2026

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 2 critical

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category Results
Security 2 critical

View in Codacy

🟢 Metrics 100 complexity · 0 duplication

Metric Results
Complexity 100
Duplication 0

View in Codacy

🟢 Coverage 27.22% diff coverage · +0.01% coverage variation

Metric Results
Coverage variation +0.01% coverage variation (-1.00%)
Diff coverage 27.22% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (283580d) 81388 18676 22.95%
Head commit (61eed98) 82022 (+634) 18827 (+151) 22.95% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2924) 654 178 27.22%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@fschade fschade requested a review from dragonchaser June 11, 2026 08:24
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
@fschade fschade merged commit 40efa88 into main Jun 11, 2026
62 of 63 checks passed
@fschade fschade deleted the next branch June 11, 2026 09:48
@openclouders openclouders mentioned this pull request Jun 11, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants