Skip to content

Custom Header: Per account#59

Open
guruz wants to merge 2 commits into
mainfrom
markus/per-account-http-header
Open

Custom Header: Per account#59
guruz wants to merge 2 commits into
mainfrom
markus/per-account-http-header

Conversation

@guruz

@guruz guruz commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

@guruz

guruz commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

@markrosan8 FYI ^

@m8426

m8426 commented Jun 3, 2026

Copy link
Copy Markdown

@guruz do you have a testflight build with this? Happy to test.

@guruz

guruz commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

Will do that and ping you today/tomorrow @m8426

@guruz guruz force-pushed the markus/per-account-http-header branch from 305fd4a to 0cb3ba7 Compare June 4, 2026 16:32
@guruz

guruz commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator Author

@guruz do you have a testflight build with this? Happy to test.

Waiting for review by Apple

@m8426

m8426 commented Jun 7, 2026

Copy link
Copy Markdown

@guruz any updates on the build? still stuck at review?

@guruz

guruz commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator Author

Yes, just checked. This is very strange, normally Testflight reviews go through very quickly

@guruz

guruz commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator Author

In any case, this is the link https://testflight.apple.com/join/2F5wWTGV

You need to wait until apple approves v1.2.3

v.1.2.2 does not have it yet.

@guruz

guruz commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Still nothing. Maybe I should re-create the build and push it to testflight again

@m8426

m8426 commented Jun 8, 2026

Copy link
Copy Markdown

Hmm very odd. Maybe you can push a new build on 1.2.2? I think only the first build per version is reviewed. But I may be wrong.

@guruz

guruz commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

1.2.3 should be out now for rtesting?

@guruz

guruz commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author
D031CD34-B1A8-43C4-B5EB-7CF1D7B48F70_1_102_o 995483DE-28A2-4842-9A27-4D75AE9455A6_1_102_o

FYI @paolostivanin
The TLS cert stuff is a no-op still.

@m8426

m8426 commented Jun 9, 2026

Copy link
Copy Markdown

@guruz just tested it,

it works well for nearly everything, except when you hold and click “open in collabora online” for office docs. i assume it’s using wkwebview or something for that feature, so the custom http stack doesn’t get applied there? haven’t had a chance to look through the code yet.

but otherwise the headers work well with my auth proxy. great work. only thing that might be needed for some is multiple header support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants