fix(native-eval): separate execution validity from diagnostic rewards - #74
Merged
Conversation
Integrate PR #64 on current main and retain its structured outcomes, run acceptance, legacy classification, and fail-closed recovery. Archive the terminal job exit code before packaging so recovery can prove completion. Keep the first exception for diagnostics while classifying later verifier or infrastructure failures for acceptance. Cover real shell exports for exits 0 and 2, post-agent failures, aggregation validity, and explicit versus unknown recovery status. Fixes #63 Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(native-eval): separate execution validity from diagnostic rewards This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased replacement for #73 (branch protection blocked the force-push there). Reviewed integration of #64: aggregation no longer retains fully invalid agent-exit runs; recovery no longer infers exit zero without an archived exit status; plus two review-found defects (missing exit status in final archives, later execution failures hidden behind earlier agent errors). Rebased onto current main preserving #72's merged behavior — conflicts were limited to CHANGELOG and adjacent fleet tests. 139 focused + 476 full-suite tests pass; autoreview clean. Credit to @vincentkoc for the original repair in #64. Fixes #63.