fix: accept Claude native trajectories - #52
Conversation
|
Codex review: needs maintainer review before merge. Reviewed August 28, 2026, 10:02 PM ET / August 29, 2026, 02:02 UTC. ClawSweeper reviewWhat this changesThe PR marks Claude Code stream-json trajectories as real harness events and adds coverage that every pinned native harness receives that classification. Merge readinessKeep open for maintainer review: current main still excludes Claude Code from real-trajectory eligibility, while this narrow fix changes the benchmark’s evidence-comparability policy and must be rebased before it can merge. Priority: P2 Review scores
Verification
How this fits togetherShellBench’s native runner captures each harness’s execution trace and writes a normalized trajectory record. Aggregation uses the recorded trajectory mode and status to decide whether a completed run can contribute to native benchmark results. flowchart LR
A[Native harness output] --> B[Claude Code stream-json parser]
B --> C[Normalized trajectory record]
C --> D[Aggregation eligibility policy]
D --> E[Native benchmark result]
Decision needed
Why: The implementation is small and current source confirms the classification gap, but admitting a trace format into benchmark eligibility is a policy decision about result comparability rather than a purely mechanical repair. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Rebase the two focused hunks onto current main, preserve the Claude Code eligibility correction, and land it only after maintainers affirm that the validated stream-json reconstruction meets the benchmark’s real-evidence standard. Do we have a high-confidence way to reproduce the issue? Yes, source-reproducible: current main writes validated Claude Code trajectories but omits Claude Code from the real-trajectory allowlist that aggregation requires for eligibility. The submitted body also reports the intended after-fix native control-run outcome. Is this the best way to solve the issue? Unclear pending policy approval: adding Claude Code is the narrowest code repair, but maintainers must first decide whether its reconstructed stream-json trace meets the same benchmark-evidence standard as accepted harnesses. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 7e117cba3bd8. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (65 earlier review cycles; latest 8 shown)
|
What does this PR do?
Marks Claude Code native trajectories as real harness events so completed Claude runs remain eligible for native aggregation.
Why?
The native runner already converts Claude Code
stream-jsonoutput intotrajectory.json, but the harness allowlist omittedclaude-code. Aggregation therefore classified otherwise valid Claude runs astrajectory_unavailable.Changes
claude-codeto the real-trajectory harness allowlistreal_harness_eventsLive proof
A native Claude Code control run completed four tasks with four result files, four valid completed results, and no infrastructure failures. Aggregation classified every trajectory as
real; the run remained ineligible only because it was intentionally marked as an exploratory four-task subset.4/40.753truerealfor all four tasks0exploratory_subsetTests
python -m pytest -qpasses locally (444 passed, 5 skipped)python -m ruff check clawbench app.py scripts testspasses locally