fix: honor --model for reconnect prompts#211
Open
skywills wants to merge 1 commit intoopenclaw:mainfrom
Open
Conversation
354599c to
a8864a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes model selection drift on persistent/reconnected sessions so per-prompt
--modelis honored consistently (including warm queue-owner paths).Root Cause
Session options were not consistently propagated through refactored queue-owner request/task boundaries, and model config updates were not always enforced immediately before the next prompt on all adapters.
Changes
sessionOptionsthrough queue submit request parsing, transport, and task execution.session/set_config_optionfor model updates (alias-friendly)session/set_modelafter config update when availableFiles Changed
src/acp/client.tssrc/acp/session-control-errors.tssrc/cli/command-handlers.tssrc/cli/queue/ipc-server.tssrc/cli/queue/ipc.tssrc/cli/queue/messages.tssrc/cli/queue/owner-env.tssrc/cli/session/contracts.tssrc/cli/session/queue-owner-process.tssrc/cli/session/queue-owner-runtime.tssrc/cli/session/runtime.tssrc/runtime/engine/connected-session.tssrc/runtime/engine/session-options.tstest/integration.test.tsValidation
corepack pnpm run typecheckcorepack pnpm run build:testnode --test --test-name-pattern "integration: prompt --model updates existing session model before prompt" dist-test/test/integration.test.jsManual Repro
npx tsx src/cli.ts --model haiku claude sessions ensure --name "acpx-test-model"npx tsx src/cli.ts --model haiku claude prompt -s acpx-test-model "What is your model name"npx tsx src/cli.ts --verbose --model sonnet claude prompt -s acpx-test-model "What is your model name"