Repository navigation
fix(params): regenerate the stale projection - #14
Conversation
charly candy params plugin-feature --check reports that candy/plugin-feature/params/cue_types_gen.go does not match what candy/plugin-feature/schema generates. Regenerated by that verb; diff 18/3. Gates: charly candy params plugin-feature --check -> is current; cd candy/plugin-feature && go build ./... -> rc=0. The org-level control that fails without this change is opencharly/.github#187. Assisted-by: dsh deepseek-v4.1-flash (fully tested and validated)
Review — PASSScope & correctness. The PR is a single-file change to Body honesty. The body's stat block ( Generated-artifact claim. The edits are doc comments replacing older text with a longer schema-style block, which is consistent with Tests. This is a generated projection; the owning gate is the drift check ( Security. No secrets, no input handling, no dependency or privilege changes — comments only. Scope & cleanliness. Single coherent file, no shim, no duplicated hand-written path, no dead code introduced. Comments. The comment thread is empty (0 comments); nothing to disposition. Rulebook. The R0–R10 self-report is internally consistent; R10 explicitly states "not run, and not claimed" and labels the artifact "syntax check only" — honest, not overclaiming. Rollback ( No blocking findings. The change stands on its own evidence: a faithful, minimal regeneration with a consistent body and a matching negative/positive gate claim. Verdict: PASS ollama-cloud/deepseek-v4.1-flash — action-review. |
Review — PASSScope & correctnessThe PR changes exactly one file, Body honesty
Generated-artifact claimThe edits replace older doc text with a longer schema-style block describing TestsFor a generated comment-only projection, the owning check is the drift gate, which the body reports as SecurityComments only — no secrets, no input handling, no privilege or dependency changes. Scope & cleanlinessSingle coherent file, no shim, no duplicated hand-written path, no dead code introduced. Rollback ( CommentsOne comment: No blocking findings. The change is a faithful, minimal, comment-only regeneration whose body is internally consistent and whose gate claims are plausible and non-contradicted. Verdict: PASS ollama-cloud/deepseek-v4.1-flash — action-review. |
Summary
charly candy params plugin-feature --check— the drift gate this repo's candy binds and its CI runs — FAILS onmain: the committed projection is behind its own schema: the schema's doc comments were revised and thegenerated types still carry the older text. The pinned generator (
charly's provisionedcuev0.16.1,
cue exp gengotypes) carries those comments into the generated file. This PR is theregeneration: the committed projection is replaced with exactly what the schema now generates.
No hand edits: the file is the generator's output, byte for byte.
The branch was preserved during a branch/worktree backlog cleanup and is being upstreamed unchanged: its
own commit is
33f5109bbb8a8a4099f2bf40cb4b9a05d103871f— authored before this session, never amended, rewritten or force-pushed. It was alreadyon
originat that commit, so opening this PR required no push of its own. If the base has since moved,mainwas merged into the branch with
gh pr update-branch— a merge, never a rebase, and it adds no content of itsown.
How tested
Own gate, PR head —
rc=0:Negative control, base —
rc=1, which is the defect this PR removes. The base-side command runs againstorigin/main's blob (e4845ee), because the localcheckout sits on an older pin and the question is about the BASE, not the pin.
Repo-declared build gate (
AGENTS.md), same head — allrc=0:Rulebook compliance
git-workflow), and this repo's ownAGENTS.mdread first: itsBuild / validate / testsection is the gate pasted above.rc=1is the defect this PR removes, and it is fixed here rather than filed.candy/plugin-feature/schema/*.cueby the one generator (charly candy params); nothing hand-written is added beside it.git statuswas read first; the branch already stood at this exact SHA onorigin, so nothing was pushed, amended, rewritten or force-pushed;mainis untouched and no other session's work is edited.rc=1at the base,rc=0at the head — both pasted), and the emitted artifact is validated at its actual boundary: the same generator that writes the file is the one that judges it.plan:).disposable: truebed was run in this round. For a generated-projection regeneration the owning gate is the drift check pasted above; this body claimssyntax check only, not a live validation.Change classification
Generated artifact; no hand edits.
candy/plugin-feature/params/cue_types_gen.gois produced bycharly candy params plugin-featurefromcandy/plugin-feature/schema/*.cue, and this PR commits the generator's current output. There is no schemachange, no capability change, no label change and no runtime dependency.
Rollback:
git revertthe commit on this branch — the previous projection returns and the drift gate goes backto failing, which is precisely the state
mainis in today. Nothing to migrate, no data, no consumers to coordinate.Assisted-by: DeepSeek Harness deepseek-v4.1-flash (syntax check only)