fix(openapi-react-query): propagate undefined errors from empty-body non-OK responses#2829
Open
EduardF1 wants to merge 2 commits into
Open
Conversation
…non-OK responses
When openapi-fetch returns { data: undefined, error: undefined, response }
for a non-OK response with an empty body (e.g. 4xx/5xx with Content-Length: 0),
the previous `if (error)` check treated the result as successful and swallowed
the failure. Fix by checking `error !== undefined || !response.ok` in queryFn,
useInfiniteQuery's queryFn, and mutationFn.
Closes openapi-ts#2070.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 193cb06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2070.
What changed and why
queryFn,useInfiniteQuery'squeryFn, andmutationFnto throw whenerror !== undefined || !response.okresponsein the two places it was missing so the non-OK HTTP status is availableScenario fixed
When
openapi-fetchreturns{ data: undefined, error: undefined, response }for a non-OK response with an empty body (e.g. a 4xx/5xx response withContent-Length: 0), the previousif (error)check treated the result as successful and silently swallowed the failure. This PR propagates those errors correctly by also checkingresponse.ok.Test plan
pnpm testpasses inpackages/openapi-react-query(40 tests, all green)queryOptions,useMutation, anduseInfiniteQuery, asserting that empty-body 500 responses are correctly rejected/thrownNotes
This is a re-submission of #2822, which was closed because the branch was accidentally created as an orphan (not based on
main) causing 1.8M spurious additions. This PR is cleanly branched frommainwith only the intended 91-line diff (10 source lines + 81 test lines).