Skip to content

feat(api): add Cyber access programs to Responses - #757

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-148
Sep 24, 2026
Merged

feat(api): add Cyber access programs to Responses#757
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-148

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds typed Responses API request and response fields for Cyber access program selection.

Changes

  • Add access_programs.cyber to response creation parameters
  • Expose the resolved Cyber access program on response objects
  • Support standard, daybreak_blue, and daybreak_red values

@jbeckwith-oai
feat(api): add Cyber access programs to Responses
04b8ba0 
Castiron-Internal-PR: openai/openai-ruby-internal#148
Castiron-Source-SHA: 44a8ceeb015778cfd5aec989cd3393e76f34245a
Castiron-Public-Base-SHA: 9e18acf
@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review September 24, 2026 00:55
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner September 24, 2026 00:55
@github-actions

github-actions Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Mixed files: 70 → 82

12 newly customized · 0 customizations removed · 0 existing customizations changed · 20 generated baselines changed

Compared 9e18acfc93ba → 04b8ba0a5a7b. Generated baselines verified.

File Result Current custom patch
lib/openai/models/beta/beta_web_search_preview_tool.rb Generated baseline changed +9 / −3
lib/openai/models/beta/beta_web_search_tool.rb Generated baseline changed +9 / −3
lib/openai/models/responses/response.rb Generated baseline changed +21 / −0
lib/openai/models/responses/response_create_params.rb Generated baseline changed +9 / −1
lib/openai/models/responses/web_search_preview_tool.rb Generated baseline changed +9 / −3
lib/openai/models/responses/web_search_tool.rb Generated baseline changed +9 / −3
lib/openai/resources/responses.rb Generated baseline changed +121 / −6
rbi/openai/models/beta/beta_web_search_preview_tool.rbi Generated baseline changed +9 / −3
rbi/openai/models/beta/beta_web_search_tool.rbi Generated baseline changed +9 / −3
rbi/openai/models/responses/response.rbi Generated baseline changed +5 / −0
rbi/openai/models/responses/response_create_params.rbi Generated baseline changed +10 / −1
rbi/openai/models/responses/web_search_preview_tool.rbi Generated baseline changed +9 / −3
rbi/openai/models/responses/web_search_tool.rbi Generated baseline changed +9 / −3
rbi/openai/resources/responses.rbi Generated baseline changed +341 / −16
sig/openai/models/beta/beta_web_search_preview_tool.rbs Generated baseline changed +6 / −2
sig/openai/models/beta/beta_web_search_tool.rbs Generated baseline changed +6 / −2
sig/openai/models/responses/response.rbs Generated baseline changed +2 / −0
sig/openai/models/responses/web_search_preview_tool.rbs Generated baseline changed +6 / −2
sig/openai/models/responses/web_search_tool.rbs Generated baseline changed +6 / −2
sig/openai/resources/responses.rbs Generated baseline changed +33 / −0
62 existing customizations unchanged
  • lib/openai.rb
  • lib/openai/client.rb
  • lib/openai/models/audio/transcription_create_response.rb
  • lib/openai/models/beta/agents/vault_status_filter.rb
  • lib/openai/models/chat/chat_completion_message.rb
  • lib/openai/models/chat/chat_completion_message_function_tool_call.rb
  • lib/openai/models/chat/completion_create_params.rb
  • lib/openai/models/image_edit_completed_event.rb
  • lib/openai/models/image_edit_partial_image_event.rb
  • lib/openai/models/image_gen_completed_event.rb
  • lib/openai/models/image_gen_partial_image_event.rb
  • lib/openai/models/images_response.rb
  • lib/openai/models/response_format_json_schema.rb
  • lib/openai/models/responses/function_tool.rb
  • lib/openai/models/responses/response_format_text_config.rb
  • lib/openai/models/responses/response_format_text_json_schema_config.rb
  • lib/openai/models/responses/response_function_tool_call.rb
  • lib/openai/models/responses/response_function_web_search.rb
  • lib/openai/models/responses/response_output_text.rb
  • lib/openai/models/responses/tool.rb
  • lib/openai/models/webhooks/webhook_endpoint_with_secret.rb
  • lib/openai/resources/beta/agents/sessions.rb
  • lib/openai/resources/beta/threads.rb
  • lib/openai/resources/chat/completions.rb
  • lib/openai/resources/containers/files.rb
  • lib/openai/resources/files.rb
  • lib/openai/resources/vector_stores/file_batches.rb
  • lib/openai/resources/vector_stores/files.rb
  • lib/openai/resources/webhooks.rb
  • rbi/openai/client.rbi
  • rbi/openai/models/beta/agents/vault_status_filter.rbi
  • rbi/openai/models/chat/chat_completion_message.rbi
  • rbi/openai/models/chat/chat_completion_message_function_tool_call.rbi
  • rbi/openai/models/chat/completion_create_params.rbi
  • rbi/openai/models/image_edit_completed_event.rbi
  • rbi/openai/models/image_edit_partial_image_event.rbi
  • rbi/openai/models/image_gen_completed_event.rbi
  • rbi/openai/models/image_gen_partial_image_event.rbi
  • rbi/openai/models/images_response.rbi
  • rbi/openai/models/response_format_json_schema.rbi

22 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35940671784 --repo openai/openai-ruby \
  --name castiron-custom-code-35940671784-1 --dir /tmp/castiron-custom-code-35940671784-1
git apply --stat /tmp/castiron-custom-code-35940671784-1/custom-code.patch
cat /tmp/castiron-custom-code-35940671784-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 9e18acfc93ba6fbedaae37bb89956b1a4cc24b49 04b8ba0a5a7b63106fcf105cdfda15da4b5a5f97
python3 scripts/castiron/custom_code_report.py report \
  --base 9e18acfc93ba6fbedaae37bb89956b1a4cc24b49 \
  --head 04b8ba0a5a7b63106fcf105cdfda15da4b5a5f97 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-04b8ba0a5a7b
cat /tmp/castiron-custom-code-04b8ba0a5a7b/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T00:57:40.654069Z 04b8ba0 Draft marked ready
🔒 Security Review ✅ Completed 2026-09-24T00:58:06.407302Z 04b8ba0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 9.131s for Ruby SDK PR #757.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 205ms
tests/chat-completions-create.test.ts ✅ Passed 261ms
tests/chat-completions-stream.test.ts ✅ Passed 147ms
tests/files-content-binary.test.ts ✅ Passed 195ms
tests/files-create-multipart.test.ts ✅ Passed 155ms
tests/files-list-pagination.test.ts ✅ Passed 159ms
tests/initialize-config.test.ts ✅ Passed 123ms
tests/instance-isolation.test.ts ✅ Passed 122ms
tests/models-list.test.ts ✅ Passed 164ms
tests/responses-background-lifecycle.test.ts ✅ Passed 202ms
tests/responses-body-method-errors.test.ts ✅ Passed 425ms
tests/responses-cancel-timeout.test.ts ✅ Passed 258ms
tests/responses-cancel.test.ts ✅ Passed 122ms
tests/responses-compact-retries.test.ts ✅ Passed 264ms
tests/responses-compact.test.ts ✅ Passed 239ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 131ms
tests/responses-create-advanced.test.ts ✅ Passed 242ms
tests/responses-create-disconnect.test.ts ✅ Passed 167ms
tests/responses-create-errors.test.ts ✅ Passed 277ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 177ms
tests/responses-create-retries.test.ts ✅ Passed 204ms
tests/responses-create-stream-failures.test.ts ✅ Passed 143ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 225ms
tests/responses-create-stream-wire.test.ts ✅ Passed 2.081s
tests/responses-create-stream.test.ts ✅ Passed 150ms
tests/responses-create-terminal-states.test.ts ✅ Passed 268ms
tests/responses-create-timeout.test.ts ✅ Passed 240ms
tests/responses-create.test.ts ✅ Passed 141ms
tests/responses-delete.test.ts ✅ Passed 194ms
tests/responses-input-items-errors.test.ts ✅ Passed 183ms
tests/responses-input-items-list.test.ts ✅ Passed 203ms
tests/responses-input-items-options.test.ts ✅ Passed 111ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 247ms
tests/responses-input-tokens-count.test.ts ✅ Passed 276ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.261s
tests/responses-not-found-errors.test.ts ✅ Passed 315ms
tests/responses-parse.test.ts ✅ Passed 210ms
tests/responses-retrieve-retries.test.ts ✅ Passed 296ms
tests/responses-retrieve.test.ts ✅ Passed 131ms
tests/responses-stored-method-errors.test.ts ✅ Passed 703ms
tests/retry-behavior.test.ts ✅ Passed 3.368s
tests/sdk-error-shape.test.ts ✅ Passed 407ms

View OkTest run #35940651566

SDK merge (0831d6276b71) · head (04b8ba0a5a7b) · base (9e18acfc93ba) · OkTest (b85ab863eaa0)

markstuart-oai
markstuart-oai approved these changes Sep 24, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all 28 changed files at 04b8ba0, including the schema, GA/Beta HTTP and WebSocket models, RBI/RBS declarations, streaming paths and response tests. The optional request selection and required-but-nullable response field match the schema, and the three Cyber values flow through the existing serializers without adding client-side selection logic. No substantive correctness or structural issues found.

Validation was source-only plus hosted CI. Ruby 3.3/3.4/4.0 tests, Bedrock tests, RBI/RBS checks, lint, packaging, and Castiron consistency/budget checks pass on this head. The linked OkTest job also passed; its hosted log confirms all 236 SDK tests passed for the merge candidate containing this head. I did not run repository workloads or live Cyber entitlement/API checks.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Sep 24, 2026
Merged via the queue into main with commit f484e4e Sep 24, 2026
22 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-148 branch September 24, 2026 02:02
@openai-sdks openai-sdks Bot mentioned this pull request Sep 23, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbeckwith-oai @markstuart-oai