chore(api): clarify Realtime modality array definitions - #756
Conversation
Castiron-Internal-PR: openai/openai-ruby-internal#150 Castiron-Source-SHA: 93648825b83b6dd5a4b0f207643d01f01ccd83ab Castiron-Public-Base-SHA: f83af03
Castiron custom code✅ No new custom-code files detected. 70 mixed files remain; 0 existing customizations changed. Compared 70 existing customizations unchanged
30 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35934037035 --repo openai/openai-ruby \
--name castiron-custom-code-35934037035-1 --dir /tmp/castiron-custom-code-35934037035-1
git apply --stat /tmp/castiron-custom-code-35934037035-1/custom-code.patch
cat /tmp/castiron-custom-code-35934037035-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin f83af03a667a7045dde39d2a9ca328432e3d109b 0d1896388e55679a8f4e71a381b88c8dd286b4df
python3 scripts/castiron/custom_code_report.py report \
--base f83af03a667a7045dde39d2a9ca328432e3d109b \
--head 0d1896388e55679a8f4e71a381b88c8dd286b4df --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-0d1896388e55
cat /tmp/castiron-custom-code-0d1896388e55/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Reviewed the complete diff from f83af03 to 0d18963. No blocking findings.
The only schema changes add type: array to RealtimeSession.modalities and RealtimeSessionCreateRequest.modalities. Item enums and optionality are preserved; no SDK source, exported types, signatures, or runtime implementation changed.
Validation: parsed the full pinned base/head schemas and confirmed exactly those two key additions; verified the transformed-schema hash against generation metadata; 20 independent positive/negative JSON Schema checks passed. The separate transcription-session schema is unchanged from the base. Exact-head hosted Ruby 3.3/3.4/4.0 and Bedrock tests, lint, RBI/RBS checks, packaging, CodeQL, and Castiron baseline/budget checks are green.
No live API calls or local SDK test suite were run.
|
Thanks @jbeckwith-oai for the independent Ruby review and schema checks. The reviewed head remains |
Summary
Clarifies retained Realtime modality arrays in the API reference without changing SDK types or method signatures.
Changes