Skip to content

chore(api): clarify approximate web search location defaults - #755

Merged
marcuswood-oai merged 1 commit into
mainfrom
castiron/promotions/pr-151
Sep 23, 2026
Merged

marcuswood-oai merged 1 commit into
mainfrom
castiron/promotions/pr-151

Conversation

@marcuswood-oai

Copy link
Copy Markdown
Contributor

Summary

Clarifies how approximate user locations affect web search results.

Changes

  • Document that omitted or null user locations default to the United States.
  • Explain how to avoid the fallback with an approximate location containing no location fields, or localize results with location fields.

Castiron-Internal-PR: openai/openai-ruby-internal#151
Castiron-Source-SHA: cebf751e8e2f2182215a53b66094333b00f15a53
Castiron-Public-Base-SHA: 4c1cd58
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

70 mixed files remain; 0 existing customizations changed.

Compared 4c1cd583ee2b → 7331b70a6099. Generated baselines verified.

70 existing customizations unchanged
  • lib/openai.rb
  • lib/openai/client.rb
  • lib/openai/models/audio/transcription_create_response.rb
  • lib/openai/models/beta/agents/vault_status_filter.rb
  • lib/openai/models/chat/chat_completion_message.rb
  • lib/openai/models/chat/chat_completion_message_function_tool_call.rb
  • lib/openai/models/chat/completion_create_params.rb
  • lib/openai/models/image_edit_completed_event.rb
  • lib/openai/models/image_edit_partial_image_event.rb
  • lib/openai/models/image_gen_completed_event.rb
  • lib/openai/models/image_gen_partial_image_event.rb
  • lib/openai/models/images_response.rb
  • lib/openai/models/response_format_json_schema.rb
  • lib/openai/models/responses/function_tool.rb
  • lib/openai/models/responses/response.rb
  • lib/openai/models/responses/response_create_params.rb
  • lib/openai/models/responses/response_format_text_config.rb
  • lib/openai/models/responses/response_format_text_json_schema_config.rb
  • lib/openai/models/responses/response_function_tool_call.rb
  • lib/openai/models/responses/response_function_web_search.rb
  • lib/openai/models/responses/response_output_text.rb
  • lib/openai/models/responses/tool.rb
  • lib/openai/models/webhooks/webhook_endpoint_with_secret.rb
  • lib/openai/resources/beta/agents/sessions.rb
  • lib/openai/resources/beta/threads.rb
  • lib/openai/resources/chat/completions.rb
  • lib/openai/resources/containers/files.rb
  • lib/openai/resources/files.rb
  • lib/openai/resources/responses.rb
  • lib/openai/resources/vector_stores/file_batches.rb
  • lib/openai/resources/vector_stores/files.rb
  • lib/openai/resources/webhooks.rb
  • rbi/openai/client.rbi
  • rbi/openai/models/beta/agents/vault_status_filter.rbi
  • rbi/openai/models/chat/chat_completion_message.rbi
  • rbi/openai/models/chat/chat_completion_message_function_tool_call.rbi
  • rbi/openai/models/chat/completion_create_params.rbi
  • rbi/openai/models/image_edit_completed_event.rbi
  • rbi/openai/models/image_edit_partial_image_event.rbi
  • rbi/openai/models/image_gen_completed_event.rbi

30 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35932284865 --repo openai/openai-ruby \
  --name castiron-custom-code-35932284865-1 --dir /tmp/castiron-custom-code-35932284865-1
git apply --stat /tmp/castiron-custom-code-35932284865-1/custom-code.patch
cat /tmp/castiron-custom-code-35932284865-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 4c1cd583ee2b79b0355fcc30f3b340c68dcfc337 7331b70a60999802cbfca9231bb82de275779602
python3 scripts/castiron/custom_code_report.py report \
  --base 4c1cd583ee2b79b0355fcc30f3b340c68dcfc337 \
  --head 7331b70a60999802cbfca9231bb82de275779602 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-7331b70a6099
cat /tmp/castiron-custom-code-7331b70a6099/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7331b70a60999802cbfca9231bb82de275779602 against 4c1cd583ee2b79b0355fcc30f3b340c68dcfc337. No blocking findings.

Parsed the pinned before/after OpenAPI documents: exactly four description values changed, with all other schema structure unchanged. The transformed-schema MD5 matches the updated generation metadata.

Checked all 12 Ruby, RBI, and RBS files. Changes are documentation comments only; nilability and model/signature types are unchanged. No API-shape, required-field, default, nullability, or serialization changes were introduced.

Hosted checks inspected: no failures or pending checks; applicable checks passed, with conditional jobs skipped.

Validation was static plus hosted CI; I did not exercise the live web-search service to independently runtime-test the documented US fallback.

@marcuswood-oai
marcuswood-oai marked this pull request as ready for review September 23, 2026 23:10
@marcuswood-oai
marcuswood-oai requested a review from a team as a code owner September 23, 2026 23:10
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T23:11:50.172298Z 7331b70 Draft marked ready
🔒 Security Review ✅ Completed 2026-09-23T23:12:32.786089Z 7331b70 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 7.361s for Ruby SDK PR #755.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 176ms
tests/chat-completions-create.test.ts ✅ Passed 201ms
tests/chat-completions-stream.test.ts ✅ Passed 150ms
tests/files-content-binary.test.ts ✅ Passed 137ms
tests/files-create-multipart.test.ts ✅ Passed 172ms
tests/files-list-pagination.test.ts ✅ Passed 173ms
tests/initialize-config.test.ts ✅ Passed 93ms
tests/instance-isolation.test.ts ✅ Passed 131ms
tests/models-list.test.ts ✅ Passed 175ms
tests/responses-background-lifecycle.test.ts ✅ Passed 117ms
tests/responses-body-method-errors.test.ts ✅ Passed 322ms
tests/responses-cancel-timeout.test.ts ✅ Passed 187ms
tests/responses-cancel.test.ts ✅ Passed 197ms
tests/responses-compact-retries.test.ts ✅ Passed 266ms
tests/responses-compact.test.ts ✅ Passed 207ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 114ms
tests/responses-create-advanced.test.ts ✅ Passed 175ms
tests/responses-create-disconnect.test.ts ✅ Passed 155ms
tests/responses-create-errors.test.ts ✅ Passed 214ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 134ms
tests/responses-create-retries.test.ts ✅ Passed 229ms
tests/responses-create-stream-failures.test.ts ✅ Passed 125ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 212ms
tests/responses-create-stream-wire.test.ts ✅ Passed 1.322s
tests/responses-create-stream.test.ts ✅ Passed 54ms
tests/responses-create-terminal-states.test.ts ✅ Passed 222ms
tests/responses-create-timeout.test.ts ✅ Passed 174ms
tests/responses-create.test.ts ✅ Passed 168ms
tests/responses-delete.test.ts ✅ Passed 152ms
tests/responses-input-items-errors.test.ts ✅ Passed 192ms
tests/responses-input-items-list.test.ts ✅ Passed 141ms
tests/responses-input-items-options.test.ts ✅ Passed 116ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 201ms
tests/responses-input-tokens-count.test.ts ✅ Passed 188ms
tests/responses-malformed-inputs.test.ts ✅ Passed 1.511s
tests/responses-not-found-errors.test.ts ✅ Passed 248ms
tests/responses-parse.test.ts ✅ Passed 173ms
tests/responses-retrieve-retries.test.ts ✅ Passed 152ms
tests/responses-retrieve.test.ts ✅ Passed 166ms
tests/responses-stored-method-errors.test.ts ✅ Passed 645ms
tests/retry-behavior.test.ts ✅ Passed 3.263s
tests/sdk-error-shape.test.ts ✅ Passed 316ms

View OkTest run #35932254402

SDK merge (1f0f55ef320a) · head (7331b70a6099) · base (4c1cd583ee2b) · OkTest (a0be4375e02d)

@marcuswood-oai
marcuswood-oai added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit f83af03 Sep 23, 2026
22 checks passed
@marcuswood-oai
marcuswood-oai deleted the castiron/promotions/pr-151 branch September 23, 2026 23:18
@openai-sdks openai-sdks Bot mentioned this pull request Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants