chore(api): clarify approximate web search location defaults - #755
Conversation
Castiron-Internal-PR: openai/openai-ruby-internal#151 Castiron-Source-SHA: cebf751e8e2f2182215a53b66094333b00f15a53 Castiron-Public-Base-SHA: 4c1cd58
Castiron custom code✅ No new custom-code files detected. 70 mixed files remain; 0 existing customizations changed. Compared 70 existing customizations unchanged
30 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35932284865 --repo openai/openai-ruby \
--name castiron-custom-code-35932284865-1 --dir /tmp/castiron-custom-code-35932284865-1
git apply --stat /tmp/castiron-custom-code-35932284865-1/custom-code.patch
cat /tmp/castiron-custom-code-35932284865-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 4c1cd583ee2b79b0355fcc30f3b340c68dcfc337 7331b70a60999802cbfca9231bb82de275779602
python3 scripts/castiron/custom_code_report.py report \
--base 4c1cd583ee2b79b0355fcc30f3b340c68dcfc337 \
--head 7331b70a60999802cbfca9231bb82de275779602 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-7331b70a6099
cat /tmp/castiron-custom-code-7331b70a6099/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed 7331b70a60999802cbfca9231bb82de275779602 against 4c1cd583ee2b79b0355fcc30f3b340c68dcfc337. No blocking findings.
Parsed the pinned before/after OpenAPI documents: exactly four description values changed, with all other schema structure unchanged. The transformed-schema MD5 matches the updated generation metadata.
Checked all 12 Ruby, RBI, and RBS files. Changes are documentation comments only; nilability and model/signature types are unchanged. No API-shape, required-field, default, nullability, or serialization changes were introduced.
Hosted checks inspected: no failures or pending checks; applicable checks passed, with conditional jobs skipped.
Validation was static plus hosted CI; I did not exercise the live web-search service to independently runtime-test the documented US fallback.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Clarifies how approximate user locations affect web search results.
Changes