feat(api): add vault metadata and clarify web search locations - #753
marcuswood-oai wants to merge 1 commit into
Conversation
Castiron-Internal-PR: openai/openai-ruby-internal#146 Castiron-Source-SHA: 5e96288df50bf4ace65aa3d4083385f3a34a0284 Castiron-Public-Base-SHA: c704778
Castiron custom code✅ No new custom-code files detected. 70 mixed files remain; 0 existing customizations changed. Compared 70 existing customizations unchanged
30 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35923531559 --repo openai/openai-ruby \
--name castiron-custom-code-35923531559-1 --dir /tmp/castiron-custom-code-35923531559-1
git apply --stat /tmp/castiron-custom-code-35923531559-1/custom-code.patch
cat /tmp/castiron-custom-code-35923531559-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin c7047782ff2ae38a859a08ef199e67a79c16b9fe 0562e9852ae1507ecaf3feb68a04a1e21b781873
python3 scripts/castiron/custom_code_report.py report \
--base c7047782ff2ae38a859a08ef199e67a79c16b9fe \
--head 0562e9852ae1507ecaf3feb68a04a1e21b781873 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-0562e9852ae1
cat /tmp/castiron-custom-code-0562e9852ae1/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed at 0562e98. No actionable findings.
Reviewed the credential models/resource surface, RBI/RBS consistency, optional update auth, required response metadata, generated fixtures, and documentation-only web-search changes. The required response-metadata/model-construction change is the explicitly documented public-beta contract change, not an accidental omission.
Validation: 40 independent assertions against this head's actual transformed schema passed, including metadata key/value/count bounds and metadata-only, empty-map clearing, auth-only, and combined updates. Verified the complete semantic schema delta and generation hash. Exact-head hosted build/lint/test checks are green (conditional jobs are skipped). I did not rerun the full SDK suite locally.
|
Closing this broader update. A separate update will contain only the web-search approximate-location documentation changes. |
Summary
Adds vault credential metadata to credential results and create/update requests, including metadata-only updates. Clarifies web search location defaults.
Changes