chore(api): correct fine-tuning bounds and Realtime response reference - #752
Conversation
Castiron-Internal-PR: openai/openai-ruby-internal#149 Castiron-Source-SHA: de28e463384ba1c1b67753497d2f35ee1f9e0adb Castiron-Public-Base-SHA: c704778
Castiron custom code✅ No new custom-code files detected. 70 mixed files remain; 0 existing customizations changed. Compared 70 existing customizations unchanged
30 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35923951363 --repo openai/openai-ruby \
--name castiron-custom-code-35923951363-1 --dir /tmp/castiron-custom-code-35923951363-1
git apply --stat /tmp/castiron-custom-code-35923951363-1/custom-code.patch
cat /tmp/castiron-custom-code-35923951363-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin c7047782ff2ae38a859a08ef199e67a79c16b9fe a34849d6459f3d50765eca417a81c243aea4cf57
python3 scripts/castiron/custom_code_report.py report \
--base c7047782ff2ae38a859a08ef199e67a79c16b9fe \
--head a34849d6459f3d50765eca417a81c243aea4cf57 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-a34849d6459f
cat /tmp/castiron-custom-code-a34849d6459f/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed exact head a34849d6459f3d50765eca417a81c243aea4cf57: no actionable findings.
Independently validated the complete two-file diff and 94 schema assertions: all seven numeric-bound/default corrections match the published OpenAPI source at 946e365dd69d52ccfe49fd0a9e565504aef517bd; boundary values, auto, invalid types, omission, and retained upper limits behave correctly. Both Realtime discriminator mappings resolve to the matching required type variants. Whole-document comparison found only those intended schema changes, and the transformed-schema hash matches the generation stats.
The SDK implementation, public language types, dependencies, and serialization code are unchanged. Raw-schema consumers do observe the intended validation/default/discriminator correction. Hosted checks were successful or conditionally skipped when checked; I did not rerun the author's language-specific compatibility suites locally.
3 participants
Summary
Corrects fine-tuning numeric bounds and Realtime client-secret response alternatives in the Ruby API reference.
Changes
Why
The API reference used boolean
exclusiveMinimumvalues, which are invalid in OpenAPI 3.1. This corrects seven numeric lower bounds and restores their existingautodefaults. Explicit discriminator mappings also identify the existingrealtimeandtranscriptionalternatives in client-secret responses.This is a reference-only correction: SDK source, public types, dependencies, and request/response serialization are unchanged.
Source: published OpenAPI correction.
Compatibility review
Reviewed head
a34849d6459f3d50765eca417a81c243aea4cf57against basec7047782ff2ae38a859a08ef199e67a79c16b9fe..castiron.stats.ymlandapi_reference/openapi.transformed.yml. All SDK source, public signatures, related model types, serializers, dependencies, and package/build configuration are unchanged. Neither changed file is consumed by the SDK runtime or enters its normal distributed code.auto, omission, and both Realtime response variants.Scope: this establishes no identified SDK-package compile-time or runtime compatibility regression from this patch. Tools that directly read the OpenAPI reference (validators, mock servers, or third-party generators) can observe the corrected bounds, defaults, and explicit mappings; those integrations are a separate compatibility surface. No deployed-service test or package release is claimed.