Skip to content

docs: clarify collaborator-only pull request policy - #750

Merged
jbeckwith-oai merged 3 commits into
mainfrom
codex/contribution-policy-20260923-openai-ruby
Sep 23, 2026
Merged

jbeckwith-oai merged 3 commits into
mainfrom
codex/contribution-policy-20260923-openai-ruby

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Make the contribution guidance match the repository's collaborator-only pull request policy. The README links to CONTRIBUTING.md, both explicitly exclude PRs from non-collaborators, and community feedback goes through issues. Existing development instructions remain available to collaborators, and security reports continue through the private disclosure process.

Retarget the existing security-model references shifted by the new contribution-policy section.
Use absolute README links to the policy and security guide so package-page readers can follow them.

Test plan

  • git diff --check and targeted policy/link checks pass.

  • Reviewed the complete diff and contributor, collaborator, and private security-reporting paths.

  • Built the gem and checked all relative README links against package contents and RDoc files.

Documentation only; no SDK runtime, repository settings, or generated source changes.

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner September 23, 2026 16:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T16:10:32.283179Z 7f71b9a PR opened
🔒 Security Review ✅ Completed 2026-09-23T16:10:39.011223Z 7f71b9a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 9.092s for Ruby SDK PR #750.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 190ms
tests/chat-completions-create.test.ts ✅ Passed 260ms
tests/chat-completions-stream.test.ts ✅ Passed 154ms
tests/files-content-binary.test.ts ✅ Passed 168ms
tests/files-create-multipart.test.ts ✅ Passed 147ms
tests/files-list-pagination.test.ts ✅ Passed 172ms
tests/initialize-config.test.ts ✅ Passed 93ms
tests/instance-isolation.test.ts ✅ Passed 178ms
tests/models-list.test.ts ✅ Passed 180ms
tests/responses-background-lifecycle.test.ts ✅ Passed 154ms
tests/responses-body-method-errors.test.ts ✅ Passed 392ms
tests/responses-cancel-timeout.test.ts ✅ Passed 209ms
tests/responses-cancel.test.ts ✅ Passed 240ms
tests/responses-compact-retries.test.ts ✅ Passed 269ms
tests/responses-compact.test.ts ✅ Passed 222ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 139ms
tests/responses-create-advanced.test.ts ✅ Passed 188ms
tests/responses-create-disconnect.test.ts ✅ Passed 150ms
tests/responses-create-errors.test.ts ✅ Passed 369ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 159ms
tests/responses-create-retries.test.ts ✅ Passed 154ms
tests/responses-create-stream-failures.test.ts ✅ Passed 139ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 215ms
tests/responses-create-stream-wire.test.ts ✅ Passed 2.064s
tests/responses-create-stream.test.ts ✅ Passed 89ms
tests/responses-create-terminal-states.test.ts ✅ Passed 255ms
tests/responses-create-timeout.test.ts ✅ Passed 194ms
tests/responses-create.test.ts ✅ Passed 209ms
tests/responses-delete.test.ts ✅ Passed 212ms
tests/responses-input-items-errors.test.ts ✅ Passed 174ms
tests/responses-input-items-list.test.ts ✅ Passed 214ms
tests/responses-input-items-options.test.ts ✅ Passed 121ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 277ms
tests/responses-input-tokens-count.test.ts ✅ Passed 235ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.291s
tests/responses-not-found-errors.test.ts ✅ Passed 304ms
tests/responses-parse.test.ts ✅ Passed 183ms
tests/responses-retrieve-retries.test.ts ✅ Passed 288ms
tests/responses-retrieve.test.ts ✅ Passed 221ms
tests/responses-stored-method-errors.test.ts ✅ Passed 804ms
tests/retry-behavior.test.ts ✅ Passed 3.246s
tests/sdk-error-shape.test.ts ✅ Passed 496ms

View OkTest run #35887264251

SDK merge (cdbe37653e91) · head (16ee347fff88) · base (265b18ae3c44) · OkTest (a0be4375e02d)

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

70 mixed files remain; 0 existing customizations changed.

Compared 265b18ae3c44 → 16ee347fff88. Generated baselines verified.

70 existing customizations unchanged
  • lib/openai.rb
  • lib/openai/client.rb
  • lib/openai/models/audio/transcription_create_response.rb
  • lib/openai/models/beta/agents/vault_status_filter.rb
  • lib/openai/models/chat/chat_completion_message.rb
  • lib/openai/models/chat/chat_completion_message_function_tool_call.rb
  • lib/openai/models/chat/completion_create_params.rb
  • lib/openai/models/image_edit_completed_event.rb
  • lib/openai/models/image_edit_partial_image_event.rb
  • lib/openai/models/image_gen_completed_event.rb
  • lib/openai/models/image_gen_partial_image_event.rb
  • lib/openai/models/images_response.rb
  • lib/openai/models/response_format_json_schema.rb
  • lib/openai/models/responses/function_tool.rb
  • lib/openai/models/responses/response.rb
  • lib/openai/models/responses/response_create_params.rb
  • lib/openai/models/responses/response_format_text_config.rb
  • lib/openai/models/responses/response_format_text_json_schema_config.rb
  • lib/openai/models/responses/response_function_tool_call.rb
  • lib/openai/models/responses/response_function_web_search.rb
  • lib/openai/models/responses/response_output_text.rb
  • lib/openai/models/responses/tool.rb
  • lib/openai/models/webhooks/webhook_endpoint_with_secret.rb
  • lib/openai/resources/beta/agents/sessions.rb
  • lib/openai/resources/beta/threads.rb
  • lib/openai/resources/chat/completions.rb
  • lib/openai/resources/containers/files.rb
  • lib/openai/resources/files.rb
  • lib/openai/resources/responses.rb
  • lib/openai/resources/vector_stores/file_batches.rb
  • lib/openai/resources/vector_stores/files.rb
  • lib/openai/resources/webhooks.rb
  • rbi/openai/client.rbi
  • rbi/openai/models/beta/agents/vault_status_filter.rbi
  • rbi/openai/models/chat/chat_completion_message.rbi
  • rbi/openai/models/chat/chat_completion_message_function_tool_call.rbi
  • rbi/openai/models/chat/completion_create_params.rbi
  • rbi/openai/models/image_edit_completed_event.rbi
  • rbi/openai/models/image_edit_partial_image_event.rbi
  • rbi/openai/models/image_gen_completed_event.rbi

30 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35887705353 --repo openai/openai-ruby \
  --name castiron-custom-code-35887705353-1 --dir /tmp/castiron-custom-code-35887705353-1
git apply --stat /tmp/castiron-custom-code-35887705353-1/custom-code.patch
cat /tmp/castiron-custom-code-35887705353-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 5aae05c4b42f9d509bdf084282a7e33ef8758adc 16ee347fff880f67ec34f1f394c2f575216bac6d
python3 scripts/castiron/custom_code_report.py report \
  --base 5aae05c4b42f9d509bdf084282a7e33ef8758adc \
  --head 16ee347fff880f67ec34f1f394c2f575216bac6d --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-16ee347fff88
cat /tmp/castiron-custom-code-16ee347fff88/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f71b9a475

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md Outdated

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16ee347. The README and contribution guide consistently direct community contributions to issues, limit pull requests to collaborators, and preserve private security reporting and the existing development instructions. The shifted security-model references point to the corresponding updated guidance. No actionable findings.

Validation: immutable documentation diff, link-target and repository-guidance inspection; exact-head hosted checks are successful or intentionally skipped. No tests or builds run locally.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit c704778 Sep 23, 2026
22 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/contribution-policy-20260923-openai-ruby branch September 23, 2026 16:53
@openai-sdks openai-sdks Bot mentioned this pull request Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants