Repository navigation
feat(api): add image edit markup overlays - #4210
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Approved. markup follows the existing file-preserving copy, extraction and multipart paths in all sync/async edit overloads. Existing mask and omission behavior remain intact. The new 24-case test checks actual multipart fields, content, filename and MIME type, caller-owned streams, error handling and captured logs across both response modes. It stays separate from generated tests.
Full diff and independent source review found no actionable issues. The generated inventory matches. The optional field adds no new processing layer or model gate; no file crosses 1,000 lines. These synthetic tests do not establish live PNG validity or mask/markup exclusivity.
Hosted CI is not green: Python 3.10 failed in test_realtime_example_keepalive.py::test_interactive_realtime_example_remains_responsive_at_input[sigint], timing out while waiting two seconds for process exit. That test is outside this diff. The job reported 20,157 passed, 218 skipped and this one failure. This approval does not establish a passing CI run.
Source-only review: no local SDK tests, builds or generation ran.
Reviewed head: 33c9fa7ed8400c92176e2b7b36b4fccd4a570fc6; base: f552fcffcf774520e946121704b5fbbf7ba986e8.
33c9fa7 to
52329ca
Compare
52329ca to
673588a
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Castiron-Internal-PR: openai/openai-python-internal#382 Castiron-Source-SHA: 1d6715c1337133d53127ad3465d881c9e1b9e64b Castiron-Public-Base-SHA: f552fcf
673588a to
e386c28
Compare
Summary
Adds an optional markup image to guide image edits.
Changes
On POSIX, the example polls stdin on the main thread instead of using a background reader. Partial input, Unicode and subsequent lines are preserved. Windows retains builtin input.
Validation: all eight example input/shutdown scenarios pass under both Pydantic versions, plus180 repeated signal cases. Tests reject fatal interpreter errors and invalid exit statuses; the original two-second deadline is unchanged. The previous daemon-reader implementation fails the strengthened tests. Formatting and lint/type checks passed. Public CI is rerunning on this updated candidate.