fix(types): parse steer responses when message type is omitted - #3794
Open
sylvesterkaczmarek wants to merge 6 commits into
Open
fix(types): parse steer responses when message type is omitted#3794sylvesterkaczmarek wants to merge 6 commits into
sylvesterkaczmarek wants to merge 6 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
sylvesterkaczmarek
left a comment
Author
There was a problem hiding this comment.
Making type optional requires dropping it as the union discriminator; otherwise valid failed-steer payloads cannot enter the message branch at all. The two branches still have disjoint required fields (role versus tool-output shape), so ordinary union validation remains well constrained. Stable and beta coverage is symmetric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
response.steerwire contract added in 3.8.0 allows a user message to omit its optionaltypefield.response.steer.failedcan return that original uncommitted input, but the generated response-side steer input model currently requirestypeand uses it as the discriminator for the message/tool-output union.As a result, a failed steer event can be valid on the wire but fail SDK validation when the original user message omitted
type.This change:
typeoptional;typediscriminator from the two-variant response-side message/tool-output union so an omitted message discriminator can be parsed;Tests
Adds stable and beta regression coverage for
response.steer.failedevents that return a user message withouttype.