Skip to content

fix: read workload token as utf-8 #3302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ghraven wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: read workload token as utf-8 #3302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/openai/auth/_workload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def k8s_service_account_token_provider(

def get_token() -> str:
try:
with open(token_file_path, "r") as f:
with open(token_file_path, "r", encoding="utf-8") as f:
token = f.read().strip()
if not token:
raise SubjectTokenProviderError(f"The token file at {token_file_path} is empty.")
Expand Down
2 changes: 1 addition & 1 deletion tests/test_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def test_workload_identity_exchange_error() -> None:

def test_k8s_service_account_token_provider(tmp_path: Path) -> None:
token_file = tmp_path / "token"
token_file.write_text("my-k8s-token")
token_file.write_text("my-k8s-token", encoding="utf-8")

provider = k8s_service_account_token_provider(token_file)

Expand Down