fix: handle empty OPENAI_BASE_URL env var by falling back to default#2939
Open
giulio-leone wants to merge 1 commit intoopenai:mainfrom
Open
fix: handle empty OPENAI_BASE_URL env var by falling back to default#2939giulio-leone wants to merge 1 commit intoopenai:mainfrom
giulio-leone wants to merge 1 commit intoopenai:mainfrom
Conversation
When `OPENAI_BASE_URL` is set to an empty string, `os.environ.get()` returns `""` instead of `None`, bypassing the default URL fallback. This causes an `APIConnectionError` since an empty string is not a valid base URL. Apply `or None` to coerce empty strings to `None`, allowing the fallback to `https://api.openai.com/v1` to activate correctly. Fixes openai#2927 Signed-off-by: Giulio Leone <6887247+giulio-leone@users.noreply.github.com>
1 task
Author
|
Friendly ping — CI is green, tests pass, rebased on latest. Ready for review whenever convenient. Happy to address any feedback. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2927 — When
OPENAI_BASE_URLis set to an empty string (e.g.,export OPENAI_BASE_URL=""), the client fails withAPIConnectionErrorinstead of falling back tohttps://api.openai.com/v1.Root Cause
os.environ.get("OPENAI_BASE_URL")returns""when the variable is set but empty. Since""is notNone, the default URL fallback is skipped.Fix
or Nonecoerces empty strings (and other falsy values) toNone, allowing the default fallback to activate. Applied to bothOpenAIandAsyncOpenAIconstructors.Tests
Added 2 new test cases (
test_base_url_env_empty_string) verifying both sync and async clients fall back to the default URL whenOPENAI_BASE_URL="". All existingtest_base_url_envtests continue to pass.