Skip to content

fix: coerce by_alias to bool in model_dump for pydantic v2 compatibility #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atian8179 wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

fix: coerce by_alias to bool in model_dump for pydantic v2 compatibility #2937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0998d8f
fix: treat empty OPENAI_BASE_URL env var as unset
atian8179 Mar 7, 2026
7c96139
fix: coerce by_alias to bool in model_dump for pydantic v2 compatibility
atian8179 Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/openai/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def __init__(
self.websocket_base_url = websocket_base_url

if base_url is None:
base_url = os.environ.get("OPENAI_BASE_URL")
base_url = os.environ.get("OPENAI_BASE_URL") or None
if base_url is None:
base_url = f"https://api.openai.com/v1"

Expand Down Expand Up @@ -536,7 +536,7 @@ def __init__(
self.websocket_base_url = websocket_base_url

if base_url is None:
base_url = os.environ.get("OPENAI_BASE_URL")
base_url = os.environ.get("OPENAI_BASE_URL") or None
if base_url is None:
base_url = f"https://api.openai.com/v1"

Expand Down
2 changes: 1 addition & 1 deletion src/openai/_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def model_dump(
exclude_defaults=exclude_defaults,
# warnings are not supported in Pydantic v1
warnings=True if PYDANTIC_V1 else warnings,
by_alias=by_alias,
by_alias=bool(by_alias) if by_alias is not None else False,
)
return cast(
"dict[str, Any]",
Expand Down