fix: treat empty OPENAI_BASE_URL env var as unset#2936
Open
atian8179 wants to merge 1 commit intoopenai:mainfrom
Open
fix: treat empty OPENAI_BASE_URL env var as unset#2936atian8179 wants to merge 1 commit intoopenai:mainfrom
atian8179 wants to merge 1 commit intoopenai:mainfrom
Conversation
When OPENAI_BASE_URL is set to an empty string, os.environ.get() returns '' instead of None, bypassing the fallback to the default API endpoint. This causes APIConnectionError. Add 'or None' to coerce empty strings to None so the default https://api.openai.com/v1 fallback is reached. Applied to both sync (OpenAI) and async (AsyncOpenAI) clients. Fixes openai#2927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
OPENAI_BASE_URLis set to an empty string (export OPENAI_BASE_URL=""), the client fails withAPIConnectionErrorinstead of falling back to the default endpoint.Root Cause
os.environ.get("OPENAI_BASE_URL")returns""(notNone) for empty env vars. The subsequentif base_url is Nonecheck doesn't trigger, so the defaulthttps://api.openai.com/v1is never assigned.Fix
Add
or Noneto coerce empty strings toNone:Applied to both
OpenAIandAsyncOpenAIclient constructors.Fixes #2927