Skip to content

chore(api): document files and uploads error responses - #1081

Merged
markstuart-oai merged 1 commit into
mainfrom
castiron/promotions/pr-152
Sep 25, 2026
Merged

markstuart-oai merged 1 commit into
mainfrom
castiron/promotions/pr-152

Conversation

@markstuart-oai

Copy link
Copy Markdown
Contributor

Summary

Documents error responses for invalid file requests, upload state, expiry, and applicable storage failures. Java exception handling is unchanged.

Changes

  • Clarify not-found and validation responses in Files and Uploads.
  • Describe when an expired upload must be restarted.

Castiron-Internal-PR: openai/openai-java-internal#152
Castiron-Source-SHA: 902e85b2629f307f607c44981cbaec8bd83e2dbf
Castiron-Public-Base-SHA: e8cbf5d
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

87 mixed files remain; 0 existing customizations changed.

Compared e8cbf5d732d4 → 4538e2e6474d. Generated baselines verified.

87 existing customizations unchanged
  • openai-java-core/src/main/kotlin/com/openai/models/audio/AudioResponseFormat.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuth.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthCreateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthRotateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionMessageFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionToolMessageParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/Embedding.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/EmbeddingCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionWebSearch.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseInputItem.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseTextConfig.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/videos/Video.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/UnwrapWebhookEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/WebhookEndpointWithSecret.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ImageServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/SkillServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/VideoServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/audio/TranscriptionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/beta/agents/SessionServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/beta/agents/SessionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/chat/ChatCompletionServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/finetuning/checkpoints/PermissionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/skills/VersionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/BetaService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/BetaServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/ResponseService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/ResponseServiceImpl.kt

47 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 36100499563 --repo openai/openai-java \
  --name castiron-custom-code-36100499563-1 --dir /tmp/castiron-custom-code-36100499563-1
git apply --stat /tmp/castiron-custom-code-36100499563-1/custom-code.patch
cat /tmp/castiron-custom-code-36100499563-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin e8cbf5d732d4f5acf7cc455ff2dc75ce91377800 4538e2e6474da1fe1ad3893eef799b6dd861cbac
python3 scripts/castiron/custom_code_report.py report \
  --base e8cbf5d732d4f5acf7cc455ff2dc75ce91377800 \
  --head 4538e2e6474da1fe1ad3893eef799b6dd861cbac --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-4538e2e6474d
cat /tmp/castiron-custom-code-4538e2e6474d/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai
markstuart-oai marked this pull request as ready for review September 25, 2026 05:53
@markstuart-oai
markstuart-oai requested a review from a team as a code owner September 25, 2026 05:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T05:56:23.030168Z 4538e2e Draft marked ready
🔒 Security Review ✅ Completed 2026-09-25T05:56:54.716433Z 4538e2e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 18.431s for Java SDK PR #1081.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 236ms
tests/chat-completions-create.test.ts ✅ Passed 775ms
tests/chat-completions-stream.test.ts ✅ Passed 1.057s
tests/files-content-binary.test.ts ✅ Passed 356ms
tests/files-create-multipart.test.ts ✅ Passed 519ms
tests/files-list-pagination.test.ts ✅ Passed 286ms
tests/initialize-config.test.ts ✅ Passed 165ms
tests/instance-isolation.test.ts ✅ Passed 244ms
tests/models-list.test.ts ✅ Passed 326ms
tests/responses-background-lifecycle.test.ts ✅ Passed 343ms
tests/responses-body-method-errors.test.ts ✅ Passed 524ms
tests/responses-cancel-timeout.test.ts ✅ Passed 237ms
tests/responses-cancel.test.ts ✅ Passed 314ms
tests/responses-compact-retries.test.ts ✅ Passed 458ms
tests/responses-compact.test.ts ✅ Passed 465ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 425ms
tests/responses-create-advanced.test.ts ✅ Passed 1.565s
tests/responses-create-disconnect.test.ts ✅ Passed 1.133s
tests/responses-create-errors.test.ts ✅ Passed 279ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 272ms
tests/responses-create-retries.test.ts ✅ Passed 333ms
tests/responses-create-stream-failures.test.ts ✅ Passed 365ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 249ms
tests/responses-create-stream-wire.test.ts ✅ Passed 7.045s
tests/responses-create-stream.test.ts ✅ Passed 111ms
tests/responses-create-terminal-states.test.ts ✅ Passed 406ms
tests/responses-create-timeout.test.ts ✅ Passed 222ms
tests/responses-create.test.ts ✅ Passed 1.066s
tests/responses-delete.test.ts ✅ Passed 310ms
tests/responses-input-items-errors.test.ts ✅ Passed 343ms
tests/responses-input-items-list.test.ts ✅ Passed 407ms
tests/responses-input-items-options.test.ts ✅ Passed 233ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 286ms
tests/responses-input-tokens-count.test.ts ✅ Passed 283ms
tests/responses-malformed-inputs.test.ts ✅ Passed 5.617s
tests/responses-not-found-errors.test.ts ✅ Passed 419ms
tests/responses-parse.test.ts ✅ Passed 720ms
tests/responses-retrieve-retries.test.ts ✅ Passed 519ms
tests/responses-retrieve.test.ts ✅ Passed 641ms
tests/responses-stored-method-errors.test.ts ✅ Passed 983ms
tests/retry-behavior.test.ts ✅ Passed 3.631s
tests/sdk-error-shape.test.ts ✅ Passed 404ms

View OkTest run #36100472493

SDK merge (1790d0899a37) · head (4538e2e6474d) · base (e8cbf5d732d4) · OkTest (bc2ef6ca05ab)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4538e2e647

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api_reference/openapi.transformed.yml
Comment thread api_reference/openapi.transformed.yml
@markstuart-oai
markstuart-oai added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 69a4e21 Sep 25, 2026
16 checks passed
@openai-sdks openai-sdks Bot mentioned this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants