Repository navigation
fix(deps-dev): bump playwright from 1.50.0 to 1.63.0 - #5402
Conversation
Bumps [playwright](https://github.com/microsoft/playwright-python) from 1.50.0 to 1.63.0. - [Release notes](https://github.com/microsoft/playwright-python/releases) - [Commits](microsoft/playwright-python@v1.50.0...v1.63.0) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.63.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the Playwright pin, pyee transitive update, lockfile artifacts, browser installation in CI, and browser API usage in examples. No in-scope compatibility blocker found. All 22 reported checks pass, including type checks and platform tests; no unresolved review threads.
|
Fixed the repeated merge-queue timeout: Python 3.14 runs coverage plus Chromium installation/browser tests, and both queue attempts reached the ten-minute job limit during slow Ubuntu package downloads after the Python tests passed. That matrix job now has a twenty-minute limit; the other Python jobs retain ten minutes. Every test step remains enabled. Validation: actionlint passed, |
|
Full local verification passed on the pushed change: formatting, lint, type checks, 12,289 parallel tests (32 skipped), and 107 serial tests (4 skipped). The source export used for validation is byte-identical to the reviewed source. Dependency versions match the lockfile, installed through the configured internal registry. Actionlint also passed for the workflow change. Remote CI is still completing its browser and Windows jobs. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed all three changed files at 9c55e3376b5ef3b2f0ad4539afd4f67486388f78. The Playwright update and lockfile agree, and only Python 3.14 gets the longer timeout. Coverage, browser tests, permissions and the other matrix timeouts stay unchanged.
Static source review only; I did not run candidate code or tests. At preflight, 23 hosted checks succeeded and 4 were skipped.
2aa50c0
|
The merge-queue run passed coverage, but the Ubuntu mirror took 12 minutes 56 seconds to download 24.4 MB of Chromium system dependencies. That exhausted the twenty-minute job budget during package unpacking, before browser tests could start. Raised only Python 3.14's job ceiling to thirty minutes so the measured seven-minute coverage workload plus thirteen-minute system installation has room for unpacking, browser downloads/tests, and teardown checks. Other Python versions retain ten minutes. Actionlint and two fresh consecutive adversarial review rounds passed. No check was removed or weakened; full local validation and fresh CI are running. |
Bumps playwright from 1.50.0 to 1.63.0.
Release notes
Sourced from playwright's releases.
... (truncated)
Commits
8cb967bcherry-pick(#3200): devops(docker): move docker publishing to Azure Pipelinesab18c77chore: roll Playwright to 1.63.0 (#3198)0e66a09devops(pipeline): resolve pip and npm packages from DevDiv_PublicPackages fee...010a9ccPin GitHub Actions to full-length commit SHAs (#3176)154f67cfix(sync): wait for initialize before leaving enter (#3168)4af2fc6chore: roll Playwright to 1.62.1 (#3169)4d2e058fix(connection): register protocol callback only after successful send (#3167)eab2bcachore(deps): remove unused development dependencies (#3164)3b7c24cchore: roll Playwright to 1.62.0 (#3161)1db079fbuild(deps): bump typing-extensions from 4.15.0 to 4.16.0 (#3162)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)