Fix non-bool approval policy results failing open - #4847
Open
mikemikimike wants to merge 1 commit into
Open
Conversation
Author
|
Local focused verification is green (ordinary Runner, MCP approval, Ruff, mypy/Pyright on touched modules). The repository's fork-triggered Tests workflows are currently completed with �ction_required; I cannot approve them from the contributor account. The PR body records the full local-suite optional-dependency and Windows limitations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Callable
needs_approvalpolicies are declared to returnbool, but a non-boolean result such asNonewas coerced withbool()and treated as approval not required. This pull request makes every non-boolean callable result fail closed by requiring approval, and routes MCP callable policies through the same evaluator so they cannot bypass the fix.Fixes #4845
Test plan
Noneand truthy non-boolean results from async approval predicates; both cases interrupt before the tool runs.None; both cases interrupt and record zero MCP calls.tests/test_run_step_execution.py, 4 passed intests/mcp/test_mcp_approval.py, and 3 passed intests/mcp/test_mcp_util.py.make formatandmake lintpassed; targeted Ruff, format, mypy, and Pyright checks passed.Issue number
Fixes #4845
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PRAI disclosure
This pull request was prepared with AI assistance. The implementation, tests, and verification results were reviewed before submission.